Test: symbol upload #763
Merged
Test: symbol upload #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parsing" This reverts commit 6b9e611.
| @@ -102,5 +102,21 @@ internal static void AddExecutableToXcodeProject(string projectPath, IDiagnostic | |||
| File.Copy(executableSource, executableDestination); | |||
| SetExecutePermission(executableDestination); | |||
| } | |||
|
|
|||
| internal static string? UrlOverride(string? dsnOption, string? urlOverrideOption) | |||
There was a problem hiding this comment.
Just for my understanding: Why go that route? Why not just take the override from the cli options? And can we get rid of the override on the cli options if we take the server from the DSN?
There was a problem hiding this comment.
Because it may not be needed to specify the override in the first place. If you've configured the DSN to be an internal server that's available during build, it should just work without specifying the same server as upload override. As is, it would try to upload to sentry.io instead, if you didn't specify any override.
Co-authored-by: Stefan Jandl <[email protected]>
bitsandfoxes
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #627
WebGL- no symbols being uploaded#skip-changelog