Integration-test building without sentry SDK only on main branch
#785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaind
force-pushed
the
fix/first-build-symbol-upload
branch
from
596f80b to
b039a35
Compare
vaind
force-pushed
the
fix/first-build-symbol-upload
branch
2 times, most recently
from
1dbf020 to
b4b64f1
Compare
it wasn't set during scripted builds...
vaind
force-pushed
the
fix/first-build-symbol-upload
branch
from
b4b64f1 to
1008fef
Compare
bitsandfoxes
approved these changes
Jun 8, 2022
| @@ -229,6 +229,8 @@ jobs: | |||
| run: sudo pwsh ./test/Scripts.Integration.Test/integration-create-project.ps1 -UnityPath "${{ env.UNITY_PATH }}" | |||
|
|
|||
| - name: Build without Sentry SDK | |||
| # This hasn't broken for many months, so disabling on PRs to speed up CI. And also to test a clean build with Sentry SDK included. | |||
There was a problem hiding this comment.
A surprise but a welcome one!
| private string _symbolUploadTask = @" | ||
| // Credentials and project settings information are stored in the sentry.properties file | ||
| gradle.taskGraph.whenReady {{ | ||
| gradle.taskGraph.allTasks[-1].doLast {{ | ||
| println 'Uploading symbols to Sentry' | ||
| println 'Uploading symbols to Sentry. You can find the full log in ./Logs/sentry-symbols-upload.log (the file content may not be strictly sequential because it\'s a merge of two streams).' |
| uploadTaskFilter = Regex.Replace(uploadTaskFilter, @"\[", "\\["); | ||
|
|
||
| gradleBuildFile = Regex.Replace(gradleBuildFile, uploadTaskFilter, ""); | ||
| var regex = new Regex(Regex.Escape(SymbolUploadTaskStartComment) + ".*" + Regex.Escape(SymbolUploadTaskEndComment), RegexOptions.Singleline); |
There was a problem hiding this comment.
Thanks for fixing that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've originally made the change to ci.yml in #773, but to my surprise, it actually broke builds - suddenly some symbols weren't uploaded. Turns out this is also reproducible locally - the first build doesn't include
*.dbg.so/*.sym.sosymbols.Update: the cause was that we relied on
PlayerSettings.GetScriptingBackend(EditorUserBuildSettings.selectedBuildTargetGroup)but ourBuilder.csdidn't actually set theEditorUserBuildSettings.selectedBuildTargetGroup. So this wasn't really an issue for end-users, just the issue of our tests.Before finally finding this out, I've thought it was the issue of Unity not putting the il2cpp symbols in the output folder, so I've originally collected these from Unity editor Data folder. I've reverted this change in the final version of the PR, but kept some refactorings that were originally needed to make it (and tests) work.
#skip-changelog