core: fix alert background #101383
Open
core: fix alert background #101383
+20
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
JonasBa
force-pushed
the
jb/alert/primary-background
branch
from
5dd13e3 to
4ade164
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
JonasBa
commented
Oct 10, 2025
| `; | ||
| } | ||
| return css` | ||
| background: ${tokens.background}; |
There was a problem hiding this comment.
@cursoragent apply the same linear gradient here as on line 119
There was a problem hiding this comment.
I modified the alert component's background styling to enhance its visual presentation and ensure a consistent appearance across different themes. This change specifically updates how alert backgrounds are rendered, moving to a more robust gradient-based approach.
- I updated the
generateAlertBackgroundfunction withinstatic/app/components/core/alert/alert.chonk.tsx. - I changed the
backgroundproperty tobackground-image, applying a layeredlinear-gradient. - This new
background-imagenow useslinear-gradient(${tokens.background})on top oflinear-gradient(${theme.colors.background.primary}), providing a more sophisticated background and ensuring a solid fallback color.
Learn more about Cursor Agents
Co-authored-by: jonas.badalic <[email protected]>
TkDodo
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix alert background so that it won't bleed into the page
CleanShot.2025-10-10.at.14.00.50.mp4