Skip to content

test(ui): Mock the onboarding learn more video #14108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2019
Merged

test(ui): Mock the onboarding learn more video #14108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions src/sentry/static/sentry/app/views/onboarding/projectSetup/learnMore.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,26 @@ import CreateSampleEventButton from 'app/views/onboarding/createSampleEventButto
import Panel from 'app/components/panels/panel';
import PanelBody from 'app/components/panels/panelBody';
import SentryTypes from 'app/sentryTypes';
import getDynamicText from 'app/utils/getDynamicText';
import space from 'app/styles/space';

const LEARN_MORE_VIDEO = 'https://player.vimeo.com/video/319554213';

const learnMoveVideo = getDynamicText({
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not great that this function is called getDynamicText

fixed: null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put placeholder text here so that people looking at the snapshots know there's a placeholder (instead of it looking like the video is just missing)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will open a separate PR to do

value: (
<iframe
src={LEARN_MORE_VIDEO}
frameBorder="0"
allow="autoplay; fullscreen"
allowFullScreen
/>
),
});

const LearnMore = ({project}) => (
<React.Fragment>
<DemoVideo>
<iframe
src={LEARN_MORE_VIDEO}
frameBorder="0"
allow="autoplay; fullscreen"
allowFullScreen
/>
</DemoVideo>

<DemoVideo>{learnMoveVideo}</DemoVideo>
<Panel>
<SampleEventPanelBody disablePadding={false}>
{tct(
Expand Down