Skip to content

build(babel): Upgrade babel deps to 7.4.4 #14359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Aug 12, 2019

No description provided.

@billyvg billyvg force-pushed the build/babel/update-babel-deps branch from 68ae0e2 to 81e6309 Compare August 12, 2019 23:17
@billyvg billyvg requested a review from dashed August 12, 2019 23:21
@dashed
Copy link
Member

dashed commented Aug 13, 2019

@billyvg how confident are you of these upgrades?

I'll cherry pick this into #14345 and let it stew for a bit.

@billyvg
Copy link
Member Author

billyvg commented Aug 13, 2019

Tests are passing ¯_(ツ)_/¯

I've generally not had issues upgrading babel (at least non-major upgrades).

Copy link
Member

@dashed dashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went thru the changelogs of babel from v7.0 to v7.5.

Looks good to me. 👍

@billyvg
Copy link
Member Author

billyvg commented Aug 13, 2019

I'll need to upgrade getsentry too

@dashed
Copy link
Member

dashed commented Aug 13, 2019

Oh true. 👍

Copy link
Member

@dashed dashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding back on my approval for a bit.

@dashed
Copy link
Member

dashed commented Aug 13, 2019

Hmm. @billyvg im running into this issue for getsentry babel/babel#10264

@billyvg
Copy link
Member Author

billyvg commented Aug 13, 2019

@dashed ah yeah, they merged a fix but no release yet.

@dashed
Copy link
Member

dashed commented Aug 15, 2019

@billyvg i think we can relax babel to v7.4.5

@billyvg billyvg force-pushed the build/babel/update-babel-deps branch from 81e6309 to cd001e1 Compare August 15, 2019 20:52
@billyvg billyvg changed the title build(babel): Upgrade babel deps to 7.5.5 build(babel): Upgrade babel deps to 7.4.4 Aug 15, 2019
Copy link
Member

@dashed dashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@billyvg billyvg force-pushed the build/babel/update-babel-deps branch from cd001e1 to 1d3cfe8 Compare August 21, 2019 21:25
@billyvg billyvg merged commit 220769a into master Aug 22, 2019
@billyvg billyvg deleted the build/babel/update-babel-deps branch August 22, 2019 20:16
billyvg added a commit that referenced this pull request Nov 12, 2019
No longer needed due to #14359

See the [release notes for [email protected]](https://babeljs.io/blog/2019/03/19/7.4.0) for more information
billyvg added a commit that referenced this pull request Nov 13, 2019
No longer needed due to #14359

See the [release notes for [email protected]](https://babeljs.io/blog/2019/03/19/7.4.0) for more information
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants