-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
build(babel): Upgrade babel deps to 7.4.4 #14359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
68ae0e2
to
81e6309
Compare
Tests are passing ¯_(ツ)_/¯ I've generally not had issues upgrading babel (at least non-major upgrades). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went thru the changelogs of babel from v7.0 to v7.5.
Looks good to me. 👍
I'll need to upgrade getsentry too |
Oh true. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holding back on my approval for a bit.
Hmm. @billyvg im running into this issue for getsentry babel/babel#10264 |
@dashed ah yeah, they merged a fix but no release yet. |
@billyvg i think we can relax babel to |
81e6309
to
cd001e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
cd001e1
to
1d3cfe8
Compare
No longer needed due to #14359 See the [release notes for [email protected]](https://babeljs.io/blog/2019/03/19/7.4.0) for more information
No longer needed due to #14359 See the [release notes for [email protected]](https://babeljs.io/blog/2019/03/19/7.4.0) for more information
No description provided.