chore(ts): Better generics for getDynamicText function #14415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Value frequently won't have the same type as fixed - is this going to be an issue? |
|
@lynnagara no it won't. TS is smart enough to adjust the types as necessary based on the arguments and the return types. For example:
|
billyvg
approved these changes
Aug 15, 2019
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We utilize generics to infer types based on the given
valueandfixedparameters, and as well as the matched types for anything consuming thegetDynamicTextfunction.By default
fixedis inferred to be the same type asvalue.This PR is a dependency for #14345