Skip to content

feat(ts): Add Client type to withAPI #14475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2019
Merged

feat(ts): Add Client type to withAPI #14475

merged 2 commits into from
Aug 21, 2019

Conversation

dashed
Copy link
Member

@dashed dashed commented Aug 21, 2019

☝️

@dashed dashed requested a review from a team August 21, 2019 21:49
@dashed dashed self-assigned this Aug 21, 2019
billyvg
billyvg approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you audit the other places where we need to update API types?

@dashed
Copy link
Member Author

dashed commented Aug 21, 2019

I will definitely audit other files for the API type in follow up PRs.

@dashed
Copy link
Member Author

dashed commented Aug 21, 2019

I updated src/sentry/static/sentry/app/views/settings/projectIncidentRules/ruleForm.tsx. Looks like it's the only other file that needs to be updated.

@billyvg
Copy link
Member

billyvg commented Aug 21, 2019

🤭

@dashed dashed mentioned this pull request Aug 21, 2019
Merged
8 tasks
@dashed dashed force-pushed the typescript-forward-slash-withAPI-with-Client-type branch from 693a7e7 to cc7df5f Compare August 21, 2019 22:05
@dashed dashed merged commit 8f7ab69 into master Aug 21, 2019
@dashed dashed deleted the typescript-forward-slash-withAPI-with-Client-type branch August 21, 2019 22:28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@billyvg billyvg billyvg approved these changes

Assignees

@dashed dashed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dashed @billyvg