Skip to content

ref: Remove "store.save-event-skips-nodestore" option from code #15568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2019
Merged

ref: Remove "store.save-event-skips-nodestore" option from code #15568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/sentry/event_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from django.utils import timezone
from django.utils.encoding import force_text

from sentry import buffer, eventtypes, eventstream, options, tsdb
from sentry import buffer, eventtypes, eventstream, tsdb
from sentry.constants import (
DEFAULT_STORE_NORMALIZER_ARGS,
LOG_LEVELS,
Expand Down Expand Up @@ -722,8 +722,7 @@ def save(self, project_id, raw=False, assume_normalized=False):
# save the event
try:
with transaction.atomic(using=router.db_for_write(Event)):
if options.get("store.save-event-skips-nodestore", True):
event.data.save()
event.data.save()
event.save()
except IntegrityError:
logger.info(
Expand Down
4 changes: 2 additions & 2 deletions src/sentry/models/event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

from semaphore.processing import StoreNormalizer

from sentry import eventtypes, options
from sentry import eventtypes
from sentry.db.models import (
BoundedBigIntegerField,
BoundedIntegerField,
Expand Down Expand Up @@ -619,7 +619,7 @@ class Event(EventCommon, Model):
ref_func=lambda x: x.project_id or x.project.id,
ref_version=2,
wrapper=EventDict,
skip_nodestore_save=options.get("store.save-event-skips-nodestore", True),
skip_nodestore_save=True,
)

objects = EventManager()
Expand Down