Skip to content

ref(typing): add typing to search utils file #40855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 2, 2022
Merged

ref(typing): add typing to search utils file #40855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ab1563f
negate the search values for NOT IN filters
barkbarkimashark Oct 31, 2022
0d9acfc
swap predicate so if we fail itll default to not negation filter
barkbarkimashark Oct 31, 2022
1469027
extract inlined issue_types to const
barkbarkimashark Oct 31, 2022
7c1f116
add typing
barkbarkimashark Oct 31, 2022
9bee339
less ambiguous types
barkbarkimashark Nov 1, 2022
71b825e
add typing to search utils and associated files
barkbarkimashark Nov 1, 2022
31a9558
proper typing
barkbarkimashark Nov 1, 2022
4893afb
PR feedback
barkbarkimashark Nov 1, 2022
8c3e232
check is not None instead of truthy
barkbarkimashark Nov 1, 2022
f91a8d6
swap out hasattr with isinstance
barkbarkimashark Nov 2, 2022
eff385d
replace TypedDict usage with docstring comment
barkbarkimashark Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ files = fixtures/mypy-stubs,
src/sentry/search/events/datasets/profiles.py,
src/sentry/search/events/types.py,
src/sentry/search/snuba/,
src/sentry/search/utils.py,
src/sentry/sentry_metrics/,
src/sentry/services/http.py,
src/sentry/services/base.py,
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/api/issue_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def convert_first_release_value(
) -> List[str]:
# TODO: This will make N queries. This should be ok, we don't typically have large
# lists of versions here, but we can look into batching it if needed.
releases = set()
releases: Set[str] = set()
for version in value:
releases.update(parse_release(version, projects, environments))
return list(releases)
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/models/group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ class GroupStatus:


# Statuses that can be queried/searched for
STATUS_QUERY_CHOICES = {
STATUS_QUERY_CHOICES: Mapping[str, int] = {
"resolved": GroupStatus.RESOLVED,
"unresolved": GroupStatus.UNRESOLVED,
"ignored": GroupStatus.IGNORED,
Expand Down
Loading