Skip to content

ref: work around mypy bug with partially-typed namespace packages #70183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2024
Merged

ref: work around mypy bug with partially-typed namespace packages #70183

merged 1 commit into from
May 2, 2024

Conversation

asottile-sentry
Copy link
Member

python/mypy#10360 (comment)

fixes:

$ mypy src/sentry/utils/kvstore/bigtable.py  src/sentry/analytics/pubsub.py 
src/sentry/analytics/pubsub.py:8: error: Module "google.cloud" has no attribute "pubsub_v1"  [attr-defined]
Found 1 error in 1 file (checked 2 source files)

@asottile-sentry asottile-sentry requested review from a team May 2, 2024 21:36
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 2, 2024
@asottile-sentry asottile-sentry enabled auto-merge (squash) May 2, 2024 21:36
@asottile-sentry asottile-sentry merged commit de4f738 into master May 2, 2024
48 checks passed
@asottile-sentry asottile-sentry deleted the asottile-work-around-mypy-bug branch May 2, 2024 22:04
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wedamija wedamija wedamija approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asottile-sentry @wedamija