Skip to content

ref: replace pytest-rerunfailures with flaky #78271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

asottile-sentry
Copy link
Member

pytest-rerunfailures does not run class teardowns in pytest 8.2+

see pytest-dev/pytest#11833

pytest-rerunfailures does not run class teardowns in pytest 8.2+

see pytest-dev/pytest#11833
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Sep 27, 2024
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented Sep 27, 2024

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
21746 5 21741 208
View the top 3 failed tests by shortest run time
tests.acceptance.test_sidebar.SidebarTest test_new_sidebar
Stack Traces | 5.22s run time
No failure message available
tests.snuba.sessions.test_sessions_v2 test_massage_unbalanced_results
Stack Traces | 5.34s run time
No failure message available
tests.acceptance.test_shared_issue.SharedIssueTest test_python_event
Stack Traces | 11.8s run time
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@getsantry
Copy link
Contributor

getsantry bot commented Oct 19, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Oct 19, 2024
@asottile-sentry asottile-sentry deleted the asottile-flaky-instead-of-rerunfailures branch November 7, 2024 20:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant