Skip to content

fix(issues): Add project id to occurrence rate limit key #79695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix(issues): Add project id to occurrence rate limit key #79695

merged 1 commit into from
Oct 24, 2024

Conversation

roggenkemper
Copy link
Member

this pr adds the project id to the occurrence rate limit key, some fingerprints can be the same across projects and we don't want to rate limit across projects

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 24, 2024
@roggenkemper roggenkemper marked this pull request as ready for review October 24, 2024 17:59
@roggenkemper roggenkemper requested a review from a team as a code owner October 24, 2024 17:59
wedamija
wedamija approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not too likely to conflict, but worth being cautious

JoshFerge
JoshFerge approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@JoshFerge
Copy link
Member

JoshFerge commented Oct 24, 2024 •
edited
Loading

Probably not too likely to conflict, but worth being cautious

hehe 😅
Screenshot 2024-10-24 at 2 08 43 PM

@roggenkemper roggenkemper enabled auto-merge (squash) October 24, 2024 18:09
@roggenkemper roggenkemper merged commit 7cceb28 into master Oct 24, 2024
50 checks passed
@roggenkemper roggenkemper deleted the roggenkemper/addprojecttoratelimit branch October 24, 2024 18:26
@wedamija
Copy link
Member

Probably not too likely to conflict, but worth being cautious

hehe 😅 Screenshot 2024-10-24 at 2 08 43 PM

Lol, I always forget about this

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshFerge JoshFerge JoshFerge approved these changes

@wedamija wedamija wedamija approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roggenkemper @JoshFerge @wedamija