Skip to content

feat(contexts): Differentiate client OS title #88536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2025
Merged

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Apr 2, 2025

part of #85732

When it's an error thrown on the backend in a Meta-Framework SDK, it has both operating systems listed in the contexts. os is then used for the server OS and client_os is used for the client-side OS.

This PR changes the title for client_os so it can be differentiated from the server OS.

image

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@s1gr1d s1gr1d requested a review from a team as a code owner April 2, 2025 11:26
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 2, 2025
@s1gr1d s1gr1d requested review from scttcper and leeandher April 2, 2025 11:26
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #88536      +/-   ##
==========================================
+ Coverage   87.72%   87.75%   +0.03%     
==========================================
  Files       10064    10012      -52     
  Lines      569158   566641    -2517     
  Branches    22352    22247     -105     
==========================================
- Hits       499269   497235    -2034     
+ Misses      69493    68990     -503     
- Partials      396      416      +20     

s1gr1d added a commit that referenced this pull request Apr 4, 2025
)

If a backend error is thrown in a Meta-Framework, the issue includes
`client_os` and `os` in the event context. However, the highlights
should only show data relevant to the backend.

Also, the runtime is more important than OS, so it's reordered.

Also fixes an issue in a test from
#86857 as `client_os` is not a
context type, but only an alias

fixes: getsentry/projects#801
part of: #85732

**Follow-up PR** 
- #88536

---

### Before


![image](https://github.com/user-attachments/assets/e972c62b-5255-4287-847a-96890590c10d)

or when it ran locally (server is macOS as well)


![image](https://github.com/user-attachments/assets/193c620a-992a-4894-8a4b-789f571b1275)


### After


![image](https://github.com/user-attachments/assets/212b7f3d-35e0-4272-b594-022ab5e64c4c)

or locally:


![image](https://github.com/user-attachments/assets/b5485af1-37ce-4f13-9733-5aaf913a6414)
@s1gr1d s1gr1d merged commit 4a5f59b into master Apr 4, 2025
42 checks passed
@s1gr1d s1gr1d deleted the sig/issue-context-os branch April 4, 2025 09:27
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
)

If a backend error is thrown in a Meta-Framework, the issue includes
`client_os` and `os` in the event context. However, the highlights
should only show data relevant to the backend.

Also, the runtime is more important than OS, so it's reordered.

Also fixes an issue in a test from
#86857 as `client_os` is not a
context type, but only an alias

fixes: getsentry/projects#801
part of: #85732

**Follow-up PR** 
- #88536

---

### Before


![image](https://github.com/user-attachments/assets/e972c62b-5255-4287-847a-96890590c10d)

or when it ran locally (server is macOS as well)


![image](https://github.com/user-attachments/assets/193c620a-992a-4894-8a4b-789f571b1275)


### After


![image](https://github.com/user-attachments/assets/212b7f3d-35e0-4272-b594-022ab5e64c4c)

or locally:


![image](https://github.com/user-attachments/assets/b5485af1-37ce-4f13-9733-5aaf913a6414)
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
part of #85732


When it's an error thrown on the **backend** in a Meta-Framework SDK, it
has both operating systems listed in the contexts. `os` is then used for
the server OS and `client_os` is used for the client-side OS.

This PR changes the title for `client_os` so it can be differentiated
from the server OS.


![image](https://github.com/user-attachments/assets/0bf536cf-bbeb-405a-a6ee-887c7e2b5fdf)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants