-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(contexts): Differentiate client OS title #88536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88536 +/- ##
==========================================
+ Coverage 87.72% 87.75% +0.03%
==========================================
Files 10064 10012 -52
Lines 569158 566641 -2517
Branches 22352 22247 -105
==========================================
- Hits 499269 497235 -2034
+ Misses 69493 68990 -503
- Partials 396 416 +20 |
scttcper
approved these changes
Apr 2, 2025
s1gr1d
added a commit
that referenced
this pull request
Apr 4, 2025
Loading
Loading status checks…
) If a backend error is thrown in a Meta-Framework, the issue includes `client_os` and `os` in the event context. However, the highlights should only show data relevant to the backend. Also, the runtime is more important than OS, so it's reordered. Also fixes an issue in a test from #86857 as `client_os` is not a context type, but only an alias fixes: getsentry/projects#801 part of: #85732 **Follow-up PR** - #88536 --- ### Before  or when it ran locally (server is macOS as well)  ### After  or locally: 
Loading status checks…
Loading status checks…
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
) If a backend error is thrown in a Meta-Framework, the issue includes `client_os` and `os` in the event context. However, the highlights should only show data relevant to the backend. Also, the runtime is more important than OS, so it's reordered. Also fixes an issue in a test from #86857 as `client_os` is not a context type, but only an alias fixes: getsentry/projects#801 part of: #85732 **Follow-up PR** - #88536 --- ### Before  or when it ran locally (server is macOS as well)  ### After  or locally: 
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
part of #85732 When it's an error thrown on the **backend** in a Meta-Framework SDK, it has both operating systems listed in the contexts. `os` is then used for the server OS and `client_os` is used for the client-side OS. This PR changes the title for `client_os` so it can be differentiated from the server OS. 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #85732
When it's an error thrown on the backend in a Meta-Framework SDK, it has both operating systems listed in the contexts.
os
is then used for the server OS andclient_os
is used for the client-side OS.This PR changes the title for
client_os
so it can be differentiated from the server OS.