Skip to content

fix(insights): show - instead of null when metric value is null #91656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DominikB2014
Copy link
Contributor

Eap returns data back as null when there is no data, while metrics would always return 0.0. When eap returns back null, we should display - to represent no data instead of the text null

image

@DominikB2014 DominikB2014 requested a review from a team as a code owner May 14, 2025 19:51
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 14, 2025
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theres also a defined() utility function that does the same thing

@DominikB2014 DominikB2014 merged commit c77916b into master May 15, 2025
41 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/dain-482-mobile-vitals-show-instead-of-null-when-data-is-missing branch May 15, 2025 14:01
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants