Open PR and add tests if confident #93127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xible naming - Replace hardcoded screenshot names with flexible pattern matching that detects any file containing 'screenshot' and ending with .jpg/.png - Maintains backwards compatibility and adds test coverage - Fixes GitHub issue #92154
github-actions
bot
added
the
Scope: Frontend
There was a problem hiding this comment.
Pull Request Overview
This PR updates the screenshot widget in Issue Details to improve file detection by removing hardcoded filename exclusions and implementing a flexible check for screenshot file names. Additionally, it adds a new test case to validate the updated logic and introduces documentation to explain these changes.
- Removed hardcoded SCREENSHOT_NAMES and implemented a flexible filename check.
- Added test coverage for various screenshot naming patterns.
- Provided documentation on improved screenshot detection.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| static/app/components/events/eventTagsAndScreenshot/screenshot/screenshotDataSection.tsx | Removed hardcoded names and updated logic to flexibly detect screenshots. |
| static/app/components/events/eventTagsAndScreenshot/index.spec.tsx | Added new test cases to validate detection of screenshots with flexible naming. |
| screenshot_detection_improvement.md | New documentation detailing the changes to screenshot detection. |
Comments suppressed due to low confidence (1)
static/app/components/events/eventTagsAndScreenshot/screenshot/screenshotDataSection.tsx:52
- [nitpick] Consider using a case-insensitive check for 'screenshot' (e.g., converting attachment.name to lowercase) to ensure that files with differently cased names are also detected.
attachments?.filter((attachment: EventAttachment) => attachment.name.includes('screenshot') && (attachment.name.endsWith('.jpg') || attachment.name.endsWith('.png'))) ?? [];
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The screenshot widget in Issue Details was updated to improve file detection.
static/app/components/events/eventTagsAndScreenshot/screenshot/screenshotDataSection.tsx, the hardcodedSCREENSHOT_NAMESarray was removed.nameincludes "screenshot" and ends with.jpgor.png. This change addresses issue Issue detail screenshot preview: Improve screenshot file detection #92154, allowing files likecrash_screenshot.pngto be displayed.static/app/components/events/eventTagsAndScreenshot/index.spec.tsxto validate the updated detection logic, ensuring files with flexible naming patterns are correctly identified and navigable.screenshot_detection_improvement.md, was created to detail these changes.