Skip to content

fix(issues): Properly display image with mimetype octet stream #93359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2025
Merged

fix(issues): Properly display image with mimetype octet stream #93359

merged 2 commits into from
Jun 11, 2025

Conversation

scttcper
Copy link
Member

adds application/octet-stream and shares mimetypes between the two files

@scttcper scttcper requested review from evanpurkhiser and a team June 11, 2025 18:36
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 11, 2025
@scttcper scttcper enabled auto-merge (squash) June 11, 2025 18:44
@scttcper scttcper merged commit 8fd1ed7 into master Jun 11, 2025
44 checks passed
@scttcper scttcper deleted the scttcper/fix-screenshot-octet branch June 11, 2025 18:46
vishnupsatish pushed a commit that referenced this pull request Jun 12, 2025
@scttcper @vishnupsatish
fix(issues): Properly display image with mimetype octet stream (#93359)
9267065
scttcper added a commit that referenced this pull request Jun 18, 2025
@scttcper
feat(issues): Fall back to image renderer
41d66cc 
We wanted to open this up the screenshot viewer (in #93211) to anyone uploading a screenshot.png but we've been erroring when the mimetype is not in our short list of allowed image mimetypes attempting to render undefined.

Also fixes a bug where I removed the rrweb viewer in #93359
@scttcper scttcper mentioned this pull request Jun 18, 2025
Merged
scttcper added a commit that referenced this pull request Jun 18, 2025
@scttcper
feat(issues): Fall back to image renderer (#93858)
f007d68 
We wanted to open this up the screenshot viewer (in
#93211) to anyone uploading a
screenshot.png but we've been erroring when the mimetype is not in our
short list of allowed image mimetypes and attempting to render
undefined.

Also fixes a bug where I removed the rrweb viewer in
#93359
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
@scttcper @andrewshie-sentry
fix(issues): Properly display image with mimetype octet stream (#93359)
716dbd0
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
@scttcper @andrewshie-sentry
feat(issues): Fall back to image renderer (#93858)
89f7480 
We wanted to open this up the screenshot viewer (in
#93211) to anyone uploading a
screenshot.png but we've been erroring when the mimetype is not in our
short list of allowed image mimetypes and attempting to render
undefined.

Also fixes a bug where I removed the rrweb viewer in
#93359
@sentry-io Sentry.io
Copy link

sentry-io bot commented Jun 25, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evanpurkhiser evanpurkhiser evanpurkhiser approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scttcper @evanpurkhiser