feat(browser_reporting): Only set headers if option is available #93641
+68
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eader (#93560) This switches our check for whether to add the `Reporting-Endpoints` header from using `staff.is_active` (which seems to be false even if the user has `is_staff = True` in the database) to using a new option, `issues.browser_reporting.reporting_endpoints_header_enabled`.
github-actions
bot
added
the
Scope: Backend
lobsterkatie
approved these changes
Jun 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93641 +/- ##
==========================================
+ Coverage 81.66% 88.04% +6.37%
==========================================
Files 10330 10330
Lines 596288 596093 -195
Branches 23163 23111 -52
==========================================
+ Hits 486957 524807 +37850
+ Misses 108875 70793 -38082
- Partials 456 493 +37 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
) Based on @lobsterkatie 's work (#93560). Only set the `Reporting-Endpoints` header if the option `issues.browser_reporting.reporting_endpoints_header_enabled` is set (since checking for `staff.is_active` is not working as expected. Handle when the DB is not accessible by the request. --------- Co-authored-by: Katie Byers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @lobsterkatie 's work (#93560).
Only set the
Reporting-Endpointsheader if the optionissues.browser_reporting.reporting_endpoints_header_enabledis set (since checking forstaff.is_activeis not working as expected.Handle when the DB is not accessible by the request.