Skip to content

feat(breadcrumbs): Add breadcrumb link max length #93663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

scttcper
Copy link
Member

Other breadcrumbs had a max length already, but not links. Add stories for breadcrumbs.

Other breadcrumbs had a max length already, but not links. Add stories for breadcrubs.
@scttcper scttcper requested a review from a team June 16, 2025 21:54
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 16, 2025
Copy link
Member

@malwilley malwilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice storybook addition

@scttcper scttcper enabled auto-merge (squash) June 16, 2025 22:00
crumbs={[
{label: 'Organization', to: '/organizations/sentry/'},
{label: 'Projects', to: '/organizations/sentry/projects/'},
{label: 'All Projects', to: '/organizations/sentry/projects/all/'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{label: 'All Projects', to: '/organizations/sentry/projects/all/'},
{label: 'All Projects', to: '/organizations/sentry/projects/'},

i think the 'all' is not needed, it leads to an error

@scttcper scttcper merged commit 36c4ba5 into master Jun 16, 2025
46 checks passed
@scttcper scttcper deleted the scttcper/breadcrumb-max-length branch June 16, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants