Skip to content

fix: Release workflow for service image #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

paul-paliychuk
Copy link
Collaborator

@paul-paliychuk paul-paliychuk commented Oct 8, 2024

Important

Adjusts job dependencies in GitHub workflows for release-graphiti-core.yml and release-service-image.yml.

  • Workflows:
    • In release-graphiti-core.yml, removed needs: build-and-start-svc from the release job.
    • In release-service-image.yml, added build_and_start_svc job using build-and-start-svc.yml and updated docker-image job to needs: build_and_start_svc.

This description was created by Ellipsis for e53c595. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e53c595 in 14 seconds

More details
  • Looked at 29 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. .github/workflows/release-graphiti-core.yml:11
  • Draft comment:
    The needs keyword for the release job was removed. Ensure that this change is intentional and that the release job does not depend on any other job to complete successfully before it starts.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR modifies the 'needs' keyword in the workflow files. It's important to ensure that the job names are consistent and correctly referenced.
2. .github/workflows/release-service-image.yml:16
  • Draft comment:
    The job docker-image uses needs: build_and_start_svc, which is correctly updated to match the job name build_and_start_svc. Ensure that the job build_and_start_svc is defined and correctly referenced in the workflow.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR modifies the 'needs' keyword in the workflow files. It's important to ensure that the job names are consistent and correctly referenced.

Workflow ID: wflow_qiavx3dBxImoTwmf


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk merged commit edfc7ac into main Oct 8, 2024
7 checks passed
@paul-paliychuk paul-paliychuk deleted the fix-release-workflow branch October 8, 2024 21:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant