Skip to content

Fix OwnedStream::present ICE #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kvark opened this issue May 21, 2015 · 0 comments · Fixed by #750
Closed

Fix OwnedStream::present ICE #749

kvark opened this issue May 21, 2015 · 0 comments · Fixed by #750
Assignees
@kvark
Labels
difficulty: easy type: bug value: medium

Comments

@kvark
Copy link
Member

kvark commented May 21, 2015

See rust-lang/rust#25679 for more info. The impl block needs to be rewritten.
@kvark kvark mentioned this issue May 22, 2015
Merged
@kvark kvark self-assigned this May 22, 2015
adamnemecek pushed a commit to adamnemecek/gfx that referenced this issue Apr 1, 2021
@bors @kvark
Merge gfx-rs#749
2d5e032 
749: Tweak the logging a bit to make debug level usable r=non-controversial a=kvark

**Connections**
Nothing

**Description**
We should have somewhat stricter guidelines on what is ok in Debug level and what not. Previously, we printed all the tracking state on each command buffer and each submit. Since these happen every frame, and the amount of stuff used by a command buffer is not really limited, this resulted in a ton of spam, hiding legitimate Debug messages.

This PR leaves the tracker state outputs for things that are one-time, such as bind groups and render bundles, but moves out the per-frame tracking to the Trace level.

**Testing**
Running wgpu-rs examples.

Co-authored-by: Dzmitry Malyshau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvark kvark

Labels
difficulty: easy type: bug value: medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactored OwnedStream to avoid ICE on present() kvark/gfx
1 participant
@kvark