Make cast_slice() work only on Pod types. #999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes structures defined with gfx_vertex_struct! and gfx_constant_struct! also marked as Pod which is not entirely correct. These structures should only contain Pod types, but there is no way to guarantee that. Fixes #974.
|
Looks good to me, thanks! |
|
@homu r+ |
|
📌 Commit 2470e4d has been approved by |
homu
added a commit
that referenced
this pull request
Jul 7, 2016
Make cast_slice() work only on Pod types. This makes structures defined with gfx_vertex_struct! and gfx_constant_struct! also marked as Pod which is not entirely correct. These structures should only contain Pod types, but there is no way to guarantee that. Fixes #974.
|
⚡ Test exempted - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes structures defined with gfx_vertex_struct! and
gfx_constant_struct! also marked as Pod which is not entirely
correct. These structures should only contain Pod types, but there is no
way to guarantee that.
Fixes #974.