Skip to content

Export function wgpu_render_pass_set_index_buffer #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2019
Merged

Export function wgpu_render_pass_set_index_buffer #329

merged 1 commit into from
Sep 7, 2019

Conversation

alichay
Copy link
Contributor

@alichay alichay commented Sep 7, 2019

The function didn't have the #[no_mangle] flag, that's all.

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!
bors r+

bors bot added a commit that referenced this pull request Sep 7, 2019
329: Export function wgpu_render_pass_set_index_buffer r=kvark a=alichay

The function didn't have the `#[no_mangle]` flag, that's all.

Co-authored-by: Alichay <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 7, 2019

Build succeeded

@bors bors bot merged commit 306dd09 into gfx-rs:master Sep 7, 2019
kvark pushed a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
375: Add water example.  r=kvark,cwfitzgerald a=OptimisticPeach

Solves gfx-rs#329, water example requested by @kvark.

I tuned it to my personal preference of visuals, however it might be different for you. 

Note: I used https://github.com/ashima/webgl-noise for 3D open simplex noise.

I've commented to explain what most of the things in the rust side of the example mean. However, I'm not 100% sure I did the best job at giving a brief overview, and wouldn't mind someone making sure my terminology/definitions are correct. 

Thanks!
Patrik

Co-authored-by: OptimisticPeach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants