[naga]: Add no_std polyfill for round_ties_even for f32 and f64
#7585
+51
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bushrat011899
changed the title
no_std polyfill for round_ties_even for f32 and f64no_std polyfill for round_ties_even for f32 and f64
6 tasks
|
This PR will actually fix |
bushrat011899
force-pushed
the
no_std-naga
branch
from
226490c to
861d264
Compare
cwfitzgerald
requested changes
Apr 27, 2025
| # Check with all features except "std". | ||
| cargo clippy --target ${{ matrix.target }} ${{ matrix.extra-flags }} -p wgpu-types --no-default-features --features strict_asserts,fragile-send-sync-non-atomic-wasm,serde,counters | ||
| cargo clippy --target ${{ matrix.target }} ${{ matrix.extra-flags }} -p naga --no-default-features --features dot-out,compact |
There was a problem hiding this comment.
This comment isn't correct for naga - I think you should pull them out into their own lines instead of attaching them.
| /// <https://github.com/rust-lang/rust/issues/96710>. | ||
| /// | ||
| /// [polyfill source]: https://github.com/imeka/ndarray-ndimage/blob/8b14b4d6ecfbc96a8a052f802e342a7049c68d8f/src/lib.rs#L98 | ||
| fn round_ties_even<T: num_traits::float::FloatCore>(x: T) -> T { |
There was a problem hiding this comment.
I am really worried about the precision of this. wgsl requires perfect rounding. When it was only used for f16 (using f64 internals) it had a ton of excess precision. But using f64 on f64 I really worry about this.
I think it would be better to take a dep on libm and call rint/rintf which use a slightly different algorithm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
round_ties_evenf16polyfill forf32andf64usingnum_traits::float::FloatCore, specifically forno_stdsupportnagato the Checkno_stdCI action now that it is MVP compatibleTesting
Squash or Rebase?
Squash
Checklist
cargo fmt.RunN/Ataplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.Notes
f32::round_ties_evenorf64::round_ties_even, since I don't believe there is substantial value added with such a feature.f16polyfill. However, there are substantial tests for this exact method in this num-traits PR I opened. This PR would just allow us to continue working onno_stdsupport while we wait for that PR to be accepted (or not).