Storage indexing, framebuffer tracking, and a bunch of validation fixes #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 26, 2019
|
Note: there is a long tail of seemingly unrelated changes here. Mostly incremental improvements. |
grovesNL
reviewed
Feb 27, 2019
wgpu-native/src/command/render.rs
Outdated
| let pipeline_layout_guard = HUB.pipeline_layouts.read(); | ||
| let pipeline_layout = pipeline_layout_guard.get(pipeline.layout_id); | ||
| let pipeline_layout = &pipeline_layout_guard[pipeline.layout_id]; | ||
| let bing_group_guard = HUB.bind_groups.read(); |
There was a problem hiding this comment.
nit: just noticed the typo bing here :)
| id | ||
| } | ||
|
|
||
| pub fn texture_create_view( |
There was a problem hiding this comment.
It doesn't seem correct long term to accept hal types in pub functions, unless we can somehow guarantee wgpu-remote will be the only consumer
There was a problem hiding this comment.
Is this going to be a problem if those entry points are not in the headers?
kvark
changed the title
|
Ok, all Vulkan validation errors are fixed now. |
bors bot
added a commit
that referenced
this pull request
Feb 27, 2019
77: Storage indexing, framebuffer tracking, and a bunch of validation fixes r=grovesNL a=kvark Closes #73 Closes #75 Closes #79 Co-authored-by: Dzmitry Malyshau <[email protected]> Co-authored-by: Dzmitry Malyshau <[email protected]>
Build succeeded |
mitchmindtree
pushed a commit
to mitchmindtree/wgpu
that referenced
this pull request
Feb 23, 2020
77: Modify examples to use PowerPreference::Default r=kvark a=danaugrs Co-authored-by: Daniel Salvadori <[email protected]>
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
77: Modify examples to use PowerPreference::Default r=kvark a=danaugrs Co-authored-by: Daniel Salvadori <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73
Closes #75
Closes #79