Skip to content

Conversation

MarijnS95
Copy link
Contributor

@MarijnS95 MarijnS95 commented Jul 27, 2025

Connections
Depends on #6876

Description
Uses the latest windows 0.62 and windows-core 0.62 releases.

https://github.com/microsoft/windows-rs/releases/tag/0.61.0
https://github.com/microsoft/windows-rs/releases/tag/63
https://github.com/microsoft/windows-rs/releases/tag/69

Testing

WGPU_BACKEND=d3d12 cargo r -p wgpu-examples hello_triangle

Squash or Rebase?
squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.
  • Replaced crate patches with actual releases.

Comment on lines 183 to 185
/// Sum of the memory reserved by all memory blocks including unallocated regions, in bytes.
// XXX: Rename to total_capacity_bytes following the rename at https://github.com/Traverse-Research/gpu-allocator/pull/266?
pub total_reserved_bytes: u64,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarijnS95 MarijnS95 changed the title [d3d12 wgl] Upgrade to windows 0.61 crates [d3d12 wgl] Upgrade to windows 0.61-0.62 crates Sep 9, 2025
@MarijnS95 MarijnS95 changed the title [d3d12 wgl] Upgrade to windows 0.61-0.62 crates [d3d12 wgl] Upgrade to windows 0.61 crates Sep 9, 2025
@MarijnS95
Copy link
Contributor Author

I would have used a version range to include the latest https://github.com/microsoft/windows-rs/releases/tag/69 release since 0.61-0.62 is mostly compatible, except that wgl.rs calls from_win32() a bunch of times which was renamed to from_thread() in microsoft/windows-rs#3701.

@MarijnS95 MarijnS95 changed the title [d3d12 wgl] Upgrade to windows 0.61 crates [d3d12 wgl] Upgrade to windows 0.62 crates Sep 30, 2025
@MarijnS95 MarijnS95 marked this pull request as ready for review September 30, 2025 19:05
@MarijnS95 MarijnS95 force-pushed the windows-0.61 branch 2 times, most recently from 4273c92 to d1d17cf Compare September 30, 2025 19:20
MarijnS95 and others added 3 commits September 30, 2025 21:25
https://github.com/microsoft/windows-rs/releases/tag/0.61.0

The latest `windows 0.59` and `windows-core 0.59` crates were
just released (strangely tagged `0.61`), including some minor code
improvements for us.  The MSRV has been bumped to `1.74`, but `wgpu` is
already on `1.76` anyway.
@MarijnS95
Copy link
Contributor Author

Pushing back into #6876

@MarijnS95 MarijnS95 closed this Sep 30, 2025
@MarijnS95 MarijnS95 deleted the windows-0.61 branch September 30, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant