Expose raw handles #8174
Open
Expose raw handles #8174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Sep 11, 2025
| } | ||
|
|
||
| impl PhysicalDeviceFeatures { | ||
| pub fn get_core(&self) -> vk::PhysicalDeviceFeatures { |
There was a problem hiding this comment.
This probably needs a better name, but this isn't a blocker.
There was a problem hiding this comment.
Yes. I don't like the name. All of the functions like this in the codebase don't have a consistent naming scheming... the closest is that many of them are get_X where X is the field. I think it would be more beautiful to have it also be raw or handle or something like that, but I tried to be consistent in this (simple) PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes a few more raw handles that I found necessary to integrate an existing C library with my Rust WGPU program through exposing the underlying Ash objects.