Skip to content

Conversation

vmobilis
Copy link
Contributor

@vmobilis vmobilis commented Feb 20, 2025

It is needed for embeddings in stable-diffusion.cpp when weight type is not f32.

And thanks for the program! )

@vmobilis
Copy link
Contributor Author

@ggerganov, it seems that my patch is wrong, the correct one is leejet/stable-diffusion.cpp#601.

@vmobilis vmobilis closed this Feb 23, 2025
@vmobilis vmobilis reopened this Feb 24, 2025
@vmobilis
Copy link
Contributor Author

On second thought, @ggerganov, maybe support of different types is still usable?

@vmobilis
Copy link
Contributor Author

On 3rd thought, it doesn't work after all... 🙃
At least for someone: leejet/stable-diffusion.cpp#601 (comment)

@vmobilis vmobilis closed this Feb 25, 2025
@vmobilis vmobilis reopened this Feb 25, 2025
@vmobilis
Copy link
Contributor Author

vmobilis commented Mar 7, 2025

@ggerganov, is anything wrong with commit now?

@ggerganov
Copy link
Member

We can merge - I thought that something was wrong based on your last comment so didn't review.

@ggerganov ggerganov merged commit c7dfe3d into ggml-org:master Mar 7, 2025
3 checks passed
@vmobilis
Copy link
Contributor Author

vmobilis commented Mar 7, 2025

@ggerganov, thank you, black images were generated even without updated concat(), and

GGML_ABORT("fatal error");
was not called when generating (and patch avoids exactly that break), therefore the error is probably somewhere else and is unrelated to commit.

@vmobilis vmobilis deleted the patch-1 branch March 7, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants