Skip to content

fix: Vulkan shader gen binary path #11037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2025
Merged

fix: Vulkan shader gen binary path #11037

merged 1 commit into from
Jan 4, 2025

Conversation

giladgd
Copy link
Contributor

@giladgd giladgd commented Jan 2, 2025

When building a project that has llama.cpp as a cmake sub-project with Vulkan on Windows, the build fails with this error:

'vulkan-shaders-gen' is not recognized as an internal or external command

This PR fixes that.

@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Jan 2, 2025
0cc4m
0cc4m approved these changes Jan 4, 2025
View reviewed changes
Copy link
Collaborator

@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@0cc4m 0cc4m merged commit c31fc8b into ggml-org:master Jan 4, 2025
48 checks passed
@giladgd giladgd deleted the vulkanShaderGenDir branch January 4, 2025 15:31
@ag2s20150909 ag2s20150909 mentioned this pull request Jan 6, 2025
Merged
tinglou pushed a commit to tinglou/llama.cpp that referenced this pull request Feb 13, 2025
@giladgd @tinglou
fix: Vulkan shader gen binary path (ggml-org#11037)
4ae501b
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Feb 26, 2025
@giladgd @NeoZhangJianyu
fix: Vulkan shader gen binary path (ggml-org#11037)
f98bf90
mglambda pushed a commit to mglambda/llama.cpp that referenced this pull request Mar 8, 2025
@giladgd @mglambda
fix: Vulkan shader gen binary path (ggml-org#11037)
1f35e29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0cc4m 0cc4m 0cc4m approved these changes

Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giladgd @0cc4m