Skip to content

Conversation

csabakecskemeti
Copy link
Contributor

MODEL_TENSOR.SSM_DT_NORM has defined twice

  1. Line 618-620 (correct for Jamba):
  MODEL_TENSOR.SSM_DT_NORM: (
      "model.layers.{bid}.mamba.dt_layernorm",  # jamba
  ),
  1. Lines 648-650 (for plamo2, overwrites the first):
  MODEL_TENSOR.SSM_DT_NORM: (
      "model.layers.layers.{bid}.mixer.dt_norm.weight",  # plamo2
  ),

This has blocked the quantization of ai21labs/AI21-Jamba-Mini-1.7

"architectures": [
"JambaForCausalLM"
],

Make sure to read the contributing guidelines before submitting a PR

@csabakecskemeti
Copy link
Contributor Author

convert_hf_to_gguf.py to f16 succeeded with AI21-Jamba-Mini-1.7

@github-actions github-actions bot added the python python script changes label Jul 31, 2025
Copy link
Collaborator

@compilade compilade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment on lines 618 to 620
MODEL_TENSOR.SSM_DT_NORM: (
"model.layers.{bid}.mamba.dt_layernorm", # jamba
),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I would have done it the other way and keep this one (since it's right near SSM_DT) instead of the other one, but it's correct like this too since the mappings are still merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change it quickly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@compilade compilade merged commit 36e5fe7 into ggml-org:master Jul 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python python script changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants