-
Notifications
You must be signed in to change notification settings - Fork 13.2k
codeowners : update + cleanup #16174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CODEOWNERS
Outdated
/ggml/src/ggml-zdnn/ @taronaeo | ||
/ggml/src/ggml.c @ggerganov | ||
/ggml/src/ggml.cpp @ggerganov | ||
/ggml/src/gguf.cpp @JohannesGaessler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to add me to gguf.cpp
/examples/batched.swift/ @ggerganov | ||
/examples/batched/ @ggerganov | ||
/examples/convert-llama2c-to-ggml/ @ggerganov | ||
/examples/deprecation-warning/ @ggerganov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/examples/deprecation-warning/ @ggerganov | |
/examples/deprecation-warning/ @ggerganov | |
/examples/diffusion/ @am17an |
I am not sure why the last commit triggered the CI workflows when the CODEOWNERS file is not listed in the |
I do notice I can't approve workflows in CI anymore, was gonna click it for this one: |
Can't merge either, my approval is invalid but it hasn't gone through a build anyway. It's a space I haven't been active in, but it's an obvious PR to approve. |
@ericcurtin CI workflows approval and merging is going to be performed only by the core maintainers who have write access to the repository. Before, all collaborators had write access, but now after #16113, there are a handful of people (mostly backend maintainers) that continue to have write access. The rest of the collaborators are assigned the Triage Github role. |
Willing to be co-CODEOWNER on:
and these possibly in future which are being discussed with @ngxson and others in #16115 :
but happy to let you decide what's most appropriate @ggerganov |
CODEOWNERS
Outdated
/examples/llama.swiftui/ @ggerganov | ||
/examples/llama.vim @ggerganov | ||
/examples/lookahead/ @ggerganov | ||
/examples/lookup/ @ggerganov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/examples/lookup/ @ggerganov | |
/examples/lookup/ @ggerganov @JohannesGaessler |
I would also be fine with maintaining that example by myself.
/ggml/src/ggml-cuda/mmq.* @JohannesGaessler | ||
/ggml/src/ggml-cuda/mmvq.* @JohannesGaessler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ggml/src/ggml-cuda/mmq.* @JohannesGaessler | |
/ggml/src/ggml-cuda/mmvq.* @JohannesGaessler | |
/ggml/src/ggml-cuda/mmf.* @JohannesGaessler | |
/ggml/src/ggml-cuda/mmq.* @JohannesGaessler | |
/ggml/src/ggml-cuda/mmvf.* @JohannesGaessler | |
/ggml/src/ggml-cuda/mmvq.* @JohannesGaessler |
* origin/master: (39 commits) ci : disable AMD workflows + update NVIDIA workflows (ggml-org#16200) ci : enable Vulkan workflow on Mac (ggml-org#16194) ggml-cpu: Respect cpumask settings (ggml-org#16164) ggml : fix uninitialized is_on_grid in quantize_row_iq3_xxs_impl (ggml-org#15928) zdnn: refactor codebase + add docs (ggml-org#16178) codeowners : add @danbev to model-conversion example [no ci] (ggml-org#16190) devops: add s390x containers (ggml-org#15915) ggml-cpu : fix typo in gemm comments [no ci] (ggml-org#16189) feat: Add conversion support in GraniteHybrid for non-hybrid (all attn) (ggml-org#16177) clang-tidy : disable warning about performance enum size (ggml-org#16127) ggml : implement set_rows with i32 index (ggml-org#16159) codeowners : update + cleanup (ggml-org#16174) common : enable `--offline` mode without curl support (ggml-org#16137) webui : fix handling incomplete chunks (ggml-org#16107) embedding : fix typos in README (ggml-org#16171) common : remove unused local variables (ggml-org#16140) ggml : extend ggml_can_fuse to work with non-sequential nodes (ggml-org#16123) ggml : add ggml_op_is_empty (ggml-org#16122) codeowners : update ownership for @ngxson and @allozuar (ggml-org#16128) Vulkan: add conv_transpose_2d operation (ggml-org#16022) ...
--------- Co-authored-by: slaren <[email protected]>
gritlm