Skip to content

Conversation

Acly
Copy link
Collaborator

@Acly Acly commented Sep 24, 2025

* don't use VULKAN_HPP_DEFAULT_DISPATCH_LOADER_DYNAMIC_STORAGE which can cause conflicts if application or other libraries do the same
@Acly Acly requested a review from 0cc4m as a code owner September 24, 2025 12:33
@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Sep 24, 2025
@Acly Acly requested a review from jeffbolznv September 24, 2025 12:34
@jeffbolznv
Copy link
Collaborator

LGTM. CC @mtavenrath who I had discussed this with, in case he wants to propose a change to vulkan-hpp to make this simpler in the future.

@talregev
Copy link

talregev commented Sep 24, 2025

Thank you! can you also duplicate your changes to ggml repo?
vcpkg take the changes from there.

@jeffbolznv
Copy link
Collaborator

llama.cpp changes get synced to ggml every week or so.

@talregev
Copy link

talregev commented Sep 24, 2025

llama.cpp changes get synced to ggml every week or so.

Thanks! Why it not the way around?

@jeffbolznv
Copy link
Collaborator

It gets synced in both directions, it just happens that most of the development occurs in this repo.

@dg0yt
Copy link
Contributor

dg0yt commented Sep 25, 2025

This change solves the linking issue originally observed in vcpkg integration tests (ggml-org/ggml#1344 (comment)).

Copy link
Collaborator

@0cc4m 0cc4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0cc4m 0cc4m merged commit 8656f5d into ggml-org:master Sep 27, 2025
63 of 65 checks passed
@dg0yt
Copy link
Contributor

dg0yt commented Sep 29, 2025

Thank!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants