-
Notifications
You must be signed in to change notification settings - Fork 13.3k
vulkan : make the vulkan.hpp dynamic dispatcher instance private #16224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Acly
commented
Sep 24, 2025
- don't use VULKAN_HPP_DEFAULT_DISPATCH_LOADER_DYNAMIC_STORAGE which can cause conflicts if application or other libraries do the same
- sync : llama.cpp ggml#1344 (comment)
- vulkan: initialize vulkan-hpp to allow using extension function pointers #15705 (comment)
* don't use VULKAN_HPP_DEFAULT_DISPATCH_LOADER_DYNAMIC_STORAGE which can cause conflicts if application or other libraries do the same
LGTM. CC @mtavenrath who I had discussed this with, in case he wants to propose a change to vulkan-hpp to make this simpler in the future. |
Thank you! can you also duplicate your changes to ggml repo? |
llama.cpp changes get synced to ggml every week or so. |
Thanks! Why it not the way around? |
It gets synced in both directions, it just happens that most of the development occurs in this repo. |
This change solves the linking issue originally observed in vcpkg integration tests (ggml-org/ggml#1344 (comment)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank! |