Skip to content

ggml : fix assert in ggml_set_unary_op #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2023
Merged

ggml : fix assert in ggml_set_unary_op #2410

merged 1 commit into from
Jul 26, 2023

Conversation

slaren
Copy link
Member

@slaren slaren commented Jul 26, 2023

The assert in ggml_set_unary_op was an assignment instead of a comparison. Changing it to a comparison wouldn't be enough either, because at the time this function is called, the op still isn't set.

There could be several ways to fix this, I chose to remove ggml_set_unary_op entirely because I don't think we will ever need to use this function outside ggml_unary_impl, and it breaks the pattern of the way that op_params is set in other ops.

@slaren slaren merged commit b5472ea into master Jul 26, 2023
@slaren slaren deleted the ggml-fix-set-unary branch July 26, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants