Skip to content

Add missing model type names #7445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2024
Merged

Add missing model type names #7445

merged 1 commit into from
May 22, 2024

Conversation

jart
Copy link
Contributor

@jart jart commented May 21, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

📈 llama.cpp server for bench-server-baseline on Standard_NC4as_T4_v3 for phi-2-q4_0: 526 iterations 🚀

Expand details for performance related PR only
  • Concurrent users: 8, duration: 10m
  • HTTP request : avg=8910.44ms p(95)=21681.74ms fails=, finish reason: stop=464 truncated=62
  • Prompt processing (pp): avg=112.7tk/s p(95)=500.84tk/s
  • Token generation (tg): avg=33.37tk/s p(95)=45.3tk/s
  • ggml-org/models/phi-2/ggml-model-q4_0.gguf parallel=8 ctx-size=16384 ngl=33 batch-size=2048 ubatch-size=256 pp=1024 pp+tg=2048 branch=typenames commit=773973a2d93252dfcdf91d179c34f8e18f0b527f

prompt_tokens_seconds

More 
---
config:
    xyChart:
        titleFontSize: 12
        width: 900
        height: 600
    themeVariables:
        xyChart:
            titleColor: "#000000"
---
xychart-beta
    title "llama.cpp bench-server-baseline on Standard_NC4as_T4_v3
 duration=10m 526 iterations"
    y-axis "llamacpp:prompt_tokens_seconds"
    x-axis "llamacpp:prompt_tokens_seconds" 1716332353 --> 1716332985
    line [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 348.69, 348.69, 348.69, 348.69, 348.69, 773.32, 773.32, 773.32, 773.32, 773.32, 859.37, 859.37, 859.37, 859.37, 859.37, 867.83, 867.83, 867.83, 867.83, 867.83, 920.73, 920.73, 920.73, 920.73, 920.73, 934.2, 934.2, 934.2, 934.2, 934.2, 921.12, 921.12, 921.12, 921.12, 921.12, 926.7, 926.7, 926.7, 926.7, 926.7, 911.01, 911.01, 911.01, 911.01, 911.01, 899.35, 899.35, 899.35, 899.35, 899.35, 910.57, 910.57, 910.57, 910.57, 910.57, 928.43, 928.43, 928.43, 928.43, 928.43, 949.75, 949.75, 949.75, 949.75, 949.75, 949.05, 949.05, 949.05, 949.05, 949.05, 926.15, 926.15, 926.15, 926.15, 926.15, 931.6, 931.6, 931.6, 931.6, 931.6, 923.43, 923.43, 923.43, 923.43, 923.43, 912.88, 912.88, 912.88, 912.88, 912.88, 901.24, 901.24, 901.24, 901.24, 901.24, 897.38, 897.38, 897.38, 897.38, 897.38, 901.54, 901.54, 901.54, 901.54, 901.54, 898.97, 898.97, 898.97, 898.97, 898.97, 901.22, 901.22, 901.22, 901.22, 901.22, 903.85, 903.85, 903.85, 903.85, 903.85, 867.11, 867.11, 867.11, 867.11, 867.11, 865.23, 865.23, 865.23, 865.23, 865.23, 866.45, 866.45, 866.45, 866.45, 866.45, 882.9, 882.9, 882.9, 882.9, 882.9, 879.42, 879.42, 879.42, 879.42, 879.42, 877.78, 877.78, 877.78, 877.78, 877.78, 877.5, 877.5, 877.5, 877.5, 877.5, 882.22, 882.22, 882.22, 882.22, 882.22, 881.36, 881.36, 881.36, 881.36, 881.36, 880.01, 880.01, 880.01, 880.01, 880.01, 881.61, 881.61, 881.61, 881.61, 881.61, 890.86, 890.86, 890.86, 890.86, 890.86, 893.76, 893.76, 893.76, 893.76, 893.76, 899.23, 899.23, 899.23, 899.23, 899.23, 895.54, 895.54, 895.54, 895.54, 895.54, 893.85, 893.85, 893.85, 893.85, 893.85, 893.97, 893.97, 893.97, 893.97, 893.97, 891.38, 891.38, 891.38, 891.38, 891.38, 899.94, 899.94, 899.94, 899.94, 899.94, 905.69, 905.69, 905.69, 905.69, 905.69, 905.53, 905.53, 905.53, 905.53, 905.53, 905.53, 905.53, 905.53, 905.53, 905.53, 901.9, 901.9, 901.9, 901.9, 901.9, 898.97, 898.97, 898.97, 898.97, 898.97, 896.97, 896.97, 896.97, 896.97, 896.97, 893.1, 893.1, 893.1, 893.1, 893.1, 886.92, 886.92, 886.92, 886.92, 886.92, 885.11, 885.11, 885.11, 885.11, 885.11, 861.95, 861.95, 861.95, 861.95, 861.95, 862.38, 862.38, 862.38, 862.38, 862.38, 864.52, 864.52, 864.52, 864.52, 864.52, 858.25, 858.25, 858.25, 858.25, 858.25, 858.09, 858.09, 858.09, 858.09, 858.09, 854.74, 854.74, 854.74, 854.74, 854.74, 855.59, 855.59, 855.59, 855.59, 855.59, 855.65, 855.65, 855.65, 855.65, 855.65, 856.73, 856.73, 856.73, 856.73, 856.73, 856.73, 856.73]
Loading
predicted_tokens_seconds
More 
---
config:
    xyChart:
        titleFontSize: 12
        width: 900
        height: 600
    themeVariables:
        xyChart:
            titleColor: "#000000"
---
xychart-beta
    title "llama.cpp bench-server-baseline on Standard_NC4as_T4_v3
 duration=10m 526 iterations"
    y-axis "llamacpp:predicted_tokens_seconds"
    x-axis "llamacpp:predicted_tokens_seconds" 1716332353 --> 1716332985
    line [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 29.43, 29.43, 29.43, 29.43, 29.43, 30.39, 30.39, 30.39, 30.39, 30.39, 31.19, 31.19, 31.19, 31.19, 31.19, 33.2, 33.2, 33.2, 33.2, 33.2, 33.03, 33.03, 33.03, 33.03, 33.03, 32.7, 32.7, 32.7, 32.7, 32.7, 33.06, 33.06, 33.06, 33.06, 33.06, 33.33, 33.33, 33.33, 33.33, 33.33, 33.37, 33.37, 33.37, 33.37, 33.37, 33.48, 33.48, 33.48, 33.48, 33.48, 33.75, 33.75, 33.75, 33.75, 33.75, 33.52, 33.52, 33.52, 33.52, 33.52, 32.7, 32.7, 32.7, 32.7, 32.7, 32.43, 32.43, 32.43, 32.43, 32.43, 32.0, 32.0, 32.0, 32.0, 32.0, 30.77, 30.77, 30.77, 30.77, 30.77, 29.16, 29.16, 29.16, 29.16, 29.16, 28.93, 28.93, 28.93, 28.93, 28.93, 29.45, 29.45, 29.45, 29.45, 29.45, 29.48, 29.48, 29.48, 29.48, 29.48, 29.59, 29.59, 29.59, 29.59, 29.59, 29.71, 29.71, 29.71, 29.71, 29.71, 29.78, 29.78, 29.78, 29.78, 29.78, 29.9, 29.9, 29.9, 29.9, 29.9, 29.84, 29.84, 29.84, 29.84, 29.84, 30.09, 30.09, 30.09, 30.09, 30.09, 30.14, 30.14, 30.14, 30.14, 30.14, 29.98, 29.98, 29.98, 29.98, 29.98, 30.01, 30.01, 30.01, 30.01, 30.01, 30.18, 30.18, 30.18, 30.18, 30.18, 30.32, 30.32, 30.32, 30.32, 30.32, 30.39, 30.39, 30.39, 30.39, 30.39, 30.54, 30.54, 30.54, 30.54, 30.54, 30.65, 30.65, 30.65, 30.65, 30.65, 30.63, 30.63, 30.63, 30.63, 30.63, 30.43, 30.43, 30.43, 30.43, 30.43, 30.31, 30.31, 30.31, 30.31, 30.31, 29.95, 29.95, 29.95, 29.95, 29.95, 29.97, 29.97, 29.97, 29.97, 29.97, 30.03, 30.03, 30.03, 30.03, 30.03, 30.15, 30.15, 30.15, 30.15, 30.15, 30.34, 30.34, 30.34, 30.34, 30.34, 30.23, 30.23, 30.23, 30.23, 30.23, 30.06, 30.06, 30.06, 30.06, 30.06, 30.06, 30.06, 30.06, 30.06, 30.06, 29.04, 29.04, 29.04, 29.04, 29.04, 28.16, 28.16, 28.16, 28.16, 28.16, 28.09, 28.09, 28.09, 28.09, 28.09, 28.13, 28.13, 28.13, 28.13, 28.13, 28.14, 28.14, 28.14, 28.14, 28.14, 28.2, 28.2, 28.2, 28.2, 28.2, 28.26, 28.26, 28.26, 28.26, 28.26, 28.41, 28.41, 28.41, 28.41, 28.41, 28.48, 28.48, 28.48, 28.48, 28.48, 28.46, 28.46, 28.46, 28.46, 28.46, 28.54, 28.54, 28.54, 28.54, 28.54, 28.52, 28.52, 28.52, 28.52, 28.52, 28.54, 28.54, 28.54, 28.54, 28.54, 28.71, 28.71, 28.71, 28.71, 28.71, 28.83, 28.83, 28.83, 28.83, 28.83, 28.88, 28.88]
Loading

Details

kv_cache_usage_ratio

More 
---
config:
    xyChart:
        titleFontSize: 12
        width: 900
        height: 600
    themeVariables:
        xyChart:
            titleColor: "#000000"
---
xychart-beta
    title "llama.cpp bench-server-baseline on Standard_NC4as_T4_v3
 duration=10m 526 iterations"
    y-axis "llamacpp:kv_cache_usage_ratio"
    x-axis "llamacpp:kv_cache_usage_ratio" 1716332353 --> 1716332985
    line [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.07, 0.07, 0.07, 0.07, 0.07, 0.3, 0.3, 0.3, 0.3, 0.3, 0.27, 0.27, 0.27, 0.27, 0.27, 0.14, 0.14, 0.14, 0.14, 0.14, 0.2, 0.2, 0.2, 0.2, 0.2, 0.25, 0.25, 0.25, 0.25, 0.25, 0.16, 0.16, 0.16, 0.16, 0.16, 0.19, 0.19, 0.19, 0.19, 0.19, 0.2, 0.2, 0.2, 0.2, 0.2, 0.11, 0.11, 0.11, 0.11, 0.11, 0.12, 0.12, 0.12, 0.12, 0.12, 0.18, 0.18, 0.18, 0.18, 0.18, 0.3, 0.3, 0.3, 0.3, 0.3, 0.25, 0.25, 0.25, 0.25, 0.25, 0.31, 0.31, 0.31, 0.31, 0.31, 0.5, 0.5, 0.5, 0.5, 0.5, 0.43, 0.43, 0.43, 0.43, 0.43, 0.33, 0.33, 0.33, 0.33, 0.33, 0.15, 0.15, 0.15, 0.15, 0.15, 0.11, 0.11, 0.11, 0.11, 0.11, 0.2, 0.2, 0.2, 0.2, 0.2, 0.19, 0.19, 0.19, 0.19, 0.19, 0.2, 0.2, 0.2, 0.2, 0.2, 0.15, 0.15, 0.15, 0.15, 0.15, 0.31, 0.31, 0.31, 0.31, 0.31, 0.13, 0.13, 0.13, 0.13, 0.13, 0.12, 0.12, 0.12, 0.12, 0.12, 0.31, 0.31, 0.31, 0.31, 0.31, 0.21, 0.21, 0.21, 0.21, 0.21, 0.09, 0.09, 0.09, 0.09, 0.09, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.23, 0.23, 0.23, 0.23, 0.23, 0.12, 0.12, 0.12, 0.12, 0.12, 0.18, 0.18, 0.18, 0.18, 0.18, 0.35, 0.35, 0.35, 0.35, 0.35, 0.17, 0.17, 0.17, 0.17, 0.17, 0.33, 0.33, 0.33, 0.33, 0.33, 0.21, 0.21, 0.21, 0.21, 0.21, 0.15, 0.15, 0.15, 0.15, 0.15, 0.09, 0.09, 0.09, 0.09, 0.09, 0.12, 0.12, 0.12, 0.12, 0.12, 0.23, 0.23, 0.23, 0.23, 0.23, 0.52, 0.52, 0.52, 0.52, 0.52, 0.59, 0.59, 0.59, 0.59, 0.59, 0.68, 0.68, 0.68, 0.68, 0.68, 0.63, 0.63, 0.63, 0.63, 0.63, 0.36, 0.36, 0.36, 0.36, 0.36, 0.23, 0.23, 0.23, 0.23, 0.23, 0.23, 0.23, 0.23, 0.23, 0.23, 0.2, 0.2, 0.2, 0.2, 0.2, 0.19, 0.19, 0.19, 0.19, 0.19, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.3, 0.3, 0.3, 0.3, 0.3, 0.14, 0.14, 0.14, 0.14, 0.14, 0.26, 0.26, 0.26, 0.26, 0.26, 0.23, 0.23, 0.23, 0.23, 0.23, 0.12, 0.12, 0.12, 0.12, 0.12, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.19, 0.19]
Loading
requests_processing
More 
---
config:
    xyChart:
        titleFontSize: 12
        width: 900
        height: 600
    themeVariables:
        xyChart:
            titleColor: "#000000"
---
xychart-beta
    title "llama.cpp bench-server-baseline on Standard_NC4as_T4_v3
 duration=10m 526 iterations"
    y-axis "llamacpp:requests_processing"
    x-axis "llamacpp:requests_processing" 1716332353 --> 1716332985
    line [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 8.0, 8.0, 8.0, 8.0, 8.0, 4.0, 4.0, 4.0, 4.0, 4.0, 8.0, 8.0, 8.0, 8.0, 8.0, 6.0, 6.0, 6.0, 6.0, 6.0, 2.0, 2.0, 2.0, 2.0, 2.0, 5.0, 5.0, 5.0, 5.0, 5.0, 3.0, 3.0, 3.0, 3.0, 3.0, 7.0, 7.0, 7.0, 7.0, 7.0, 6.0, 6.0, 6.0, 6.0, 6.0, 7.0, 7.0, 7.0, 7.0, 7.0, 8.0, 8.0, 8.0, 8.0, 8.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 7.0, 7.0, 7.0, 7.0, 7.0, 6.0, 6.0, 6.0, 6.0, 6.0, 5.0, 5.0, 5.0, 5.0, 5.0, 2.0, 2.0, 2.0, 2.0, 2.0, 2.0, 2.0, 2.0, 2.0, 2.0, 2.0, 2.0, 2.0, 2.0, 2.0, 3.0, 3.0, 3.0, 3.0, 3.0, 7.0, 7.0, 7.0, 7.0, 7.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 5.0, 5.0, 5.0, 5.0, 5.0, 6.0, 6.0, 6.0, 6.0, 6.0, 3.0, 3.0, 3.0, 3.0, 3.0, 4.0, 4.0, 4.0, 4.0, 4.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 5.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 5.0, 5.0, 5.0, 5.0, 5.0, 7.0, 7.0, 7.0, 7.0, 7.0, 7.0, 7.0, 7.0, 7.0, 7.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 6.0, 8.0, 8.0, 8.0, 8.0, 8.0, 5.0, 5.0, 5.0, 5.0, 5.0, 7.0, 7.0, 7.0, 7.0, 7.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 6.0, 6.0, 6.0, 6.0, 6.0, 2.0, 2.0, 2.0, 2.0, 2.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 8.0, 3.0, 3.0, 3.0, 3.0, 3.0, 4.0, 4.0, 4.0, 4.0, 4.0, 5.0, 5.0, 5.0, 5.0, 5.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 4.0, 6.0, 6.0, 6.0, 6.0, 6.0, 7.0, 7.0, 7.0, 7.0, 7.0, 4.0, 4.0, 4.0, 4.0, 4.0, 6.0, 6.0, 6.0, 6.0, 6.0, 3.0, 3.0, 3.0, 3.0, 3.0, 4.0, 4.0, 4.0, 4.0, 4.0, 2.0, 2.0]
Loading

compilade
compilade approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@compilade compilade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. These were existing type names without an actual string name defined.

@compilade compilade added bugfix fixes an issue or bug Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix merge ready indicates that this may be ready to merge soon and is just holding out in case of objections labels May 21, 2024
@ggerganov ggerganov merged commit 03d8900 into ggml-org:master May 22, 2024
65 of 76 checks passed
teleprint-me pushed a commit to teleprint-me/llama.cpp that referenced this pull request May 23, 2024
@jart @teleprint-me
llama : add missing model type names (ggml-org#7445)
930c506
@icecream95 icecream95 mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compilade compilade compilade approved these changes

Assignees
No one assigned
Labels
bugfix fixes an issue or bug merge ready indicates that this may be ready to merge soon and is just holding out in case of objections Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jart @compilade @ggerganov