py: add_array() will not add to kv store if value is an empty array #8774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofosyne
added
bugfix
compilade
approved these changes
Jul 30, 2024
mofosyne
force-pushed
the
8769-bug-valueerror-invalid-gguf-metadata-value-type-or-value-due-to-missing-tags-in-the-model-card
branch
from
6ad1fdb to
02665ba
Compare
I was wondering if there was a specific reason for `if val` but good to hear we can safely use `len(val == 0` Co-authored-by: compilade <[email protected]>
mofosyne
added
the
merge ready
|
Happy for any maintainers to press merge if all checks passes and they don't spot anything. (The force push was to remove f-string marker that was caught by flake8) |
mofosyne
deleted the
8769-bug-valueerror-invalid-gguf-metadata-value-type-or-value-due-to-missing-tags-in-the-model-card
branch
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Aug 2, 2024
…gml-org#8774) * gguf_writer.py: add_array() should not add to kv store if empty * Apply suggestions from code review I was wondering if there was a specific reason for `if val` but good to hear we can safely use `len(val == 0` Co-authored-by: compilade <[email protected]> --------- Co-authored-by: compilade <[email protected]>
4 tasks
mccoylstevens
pushed a commit
to mccoylstevens/llama.cpp
that referenced
this pull request
May 15, 2025
…gml-org#8774) * gguf_writer.py: add_array() should not add to kv store if empty * Apply suggestions from code review I was wondering if there was a specific reason for `if val` but good to hear we can safely use `len(val == 0` Co-authored-by: compilade <[email protected]> --------- Co-authored-by: compilade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem in #8769 replicated and traced to add_array() adding an empty array to be written to kv store. We don't allow empty array in kv metadata store.