common : use common_ prefix for common library functions #9805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
force-pushed
the
sl/rename-common-funcs
branch
from
09ee5f9 to
4f7e4b5
Compare
|
There are probably other functions that should be renamed as well - this was just a quick pass over |
|
Yes, this is a good change. |
|
Should I also rename the |
|
Yes, along with the structs and enums (e.g. |
slaren
force-pushed
the
sl/rename-common-funcs
branch
from
13b4249 to
3c0b862
Compare
slaren
force-pushed
the
sl/rename-common-funcs
branch
from
1f1d6f4 to
6ea0304
Compare
slaren
commented
Oct 9, 2024
common/common.h
Outdated
Comment on lines
413
to
416
| struct common_init_result common_init_from_common_params(common_params & params); | ||
|
|
||
| struct llama_model_params llama_model_params_from_gpt_params (const gpt_params & params); | ||
| struct llama_context_params llama_context_params_from_gpt_params (const gpt_params & params); | ||
| struct llama_model_params common_model_params_from_common_params (const common_params & params); | ||
| struct llama_context_params common_context_params_from_common_params(const common_params & params); |
There was a problem hiding this comment.
These functions may need better names now.
There was a problem hiding this comment.
common_init_from_common_params -> common_init_from_params
Maybe:
common_model_params_from_common_params -> common_model_params_to_llama
common_context_params_from_common_params -> common_context_params_to_llama
ggerganov
approved these changes
Oct 9, 2024
4 tasks
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
* common : use common_ prefix for common library functions --------- Co-authored-by: Georgi Gerganov <[email protected]>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
* common : use common_ prefix for common library functions --------- Co-authored-by: Georgi Gerganov <[email protected]>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
* common : use common_ prefix for common library functions --------- Co-authored-by: Georgi Gerganov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefix common library functions with
common_instead ofllama_to make it clear that these functions do not belong to the base API.