Fix crash when ggml_backend_metal_init() fails on old Apple device. #1582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t call ggml_backend_metal_supports_family() when backend_gpu in NULL;
|
I think some of this was fixed in ggml-org/ggml#620 |
|
I found out that this issue seems to have been fixed in a certain update, thanks for your work. Since the issue has been resolved, I'm now closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ggml_backend_metal_init() fails (e.g. iPad Pro M1 2nd Gen), a valid struct is still returned but
ctxis null.A subsequent call to ggml_backend_metal_supports_family() crashes because is ctx is null.
So this PR implements:
Return NULL from ggml_backend_metal_init() when context is NULL.
Don't call ggml_backend_metal_supports_family() when backend_gpu is NULL;