Fix bamboo build number being empty #1
Merged
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I noticed, that the field
git.build.number
was empty on our Bamboo (v7.2.3). After a bit of digging, I found that it has to do with the environment variables which the plugin is reading. It's readingbamboo.buildNumber
andBAMBOO_BUILDNUMBER
, however bamboo is only settingbamboo_buildNumber
.In the documentation (https://confluence.atlassian.com/bamboo/bamboo-variables-289277087.html#Bamboovariables-Systemvariables) under "System variables" it is explained that "Bamboo Variables" are converted to shell variables by converting any dot to an underscore. My understanding is that Bamboo Variables like "bamboo.buildNumber" are only substituted when used in a command or script task in Bamboo.
Contributor Checklist
mvn clean package
checkstyle
coding style definition:mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B