forked from git/git
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Closed
git-for-windows/build-extra
#486Description
trace2: remove inaccurate warning and add UI helper exit calls (#1114)
Remove warning about being unable to set up tracing from Trace2
TryParseSettings method. This method should just check to see whether
TRACE2 is enabled - if it is not, it does not need to warn the user, as
we only collect traces from those who actively choose to opt in.
Additionally, GCM's UI helpers are connected to the TRACE2 system via
the Start() call in `ApplicationBase.cs`. Since this call records
`Version` and `Start` events, ensure a corresponding `Exit` event is
called before the helper process completes.
https://github.com/GitCredentialManager/git-credential-manager/releases/tag/v2.0.931