ARM64: Embed manifest properly #4718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winuser.h contains the definition of RT_MANIFEST that our LLVM based toolchain needs to understand that we want to embed compat/win32/git.manifest as an application manifest. It currently just embeds it as additional data that Windows doesn't understand. This also helps our GCC based toolchain understand that we only want one copy embedded. It currently embeds one working assembly manifest and one nearly identical, but useless copy as additional data. This also teaches our Visual Studio based buildsystems to pick up the manifest file from git.rc. This means we don't have to explicitly specify it in contrib/buildsystems/Generators/Vcxproj.pm anymore. Slightly counter-intuitively this also means we have to explicitly tell Cmake not to embed a default manifest. This fixes git-for-windows#4707 Signed-off-by: Matthias Aßhauer <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 7, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 7, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 7, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 7, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
dscho
added a commit
that referenced
this pull request
Dec 10, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
dscho
added a commit
that referenced
this pull request
Dec 10, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
dscho
added a commit
that referenced
this pull request
Dec 10, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 11, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 11, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 13, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
dscho
added a commit
that referenced
this pull request
Dec 13, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
dscho
added a commit
that referenced
this pull request
Dec 14, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 14, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 14, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 15, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 15, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 18, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 19, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 19, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
dscho
added a commit
that referenced
this pull request
Dec 19, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 19, 2023
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
dscho
added a commit
that referenced
this pull request
Sep 29, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 30, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 30, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 2, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 2, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
dscho
added a commit
that referenced
this pull request
Oct 2, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 3, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 3, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 5, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 5, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 5, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 6, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 6, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 6, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
dscho
added a commit
that referenced
this pull request
Oct 7, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
dscho
added a commit
that referenced
this pull request
Oct 7, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 7, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 7, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 7, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 8, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 8, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 8, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 8, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 8, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 8, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 8, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 10, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 10, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 10, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 10, 2025
Teach our ARM64 based builds to embed the manifest file correctly. This fixes #4707
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach our ARM64 based builds to embed the manifest file correctly.
This fixes #4707