Skip to content

Add x64 and x86_64 to user agent regex #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2020
Merged

Add x64 and x86_64 to user agent regex #1468

merged 1 commit into from
May 26, 2020

Conversation

aaronfranke
Copy link
Contributor

Fixes #1467

As noted in the issue, ARM is explicitly not included here. Just WOW64, Win64, x64, and x86_64.

@peff
Copy link
Member

peff commented May 26, 2020

Thanks, this seems like an obvious and easy improvement, even if we later go further with ARM, moving the check to client-side, etc.

@peff
Copy link
Member

peff commented May 26, 2020

I don't think we have any real way of testing this meaningfully. Presumably it works for you, but the big question is whether anybody would see a false positive. I tend to doubt it based on those patterns, so I'll merge and we'll keep an eye open for anybody opening an issue (but again, I'd be surprised if we see one).

@peff peff merged commit 7cdd411 into git:master May 26, 2020
@peff
Copy link
Member

peff commented May 26, 2020

One interesting implication: on my 64-bit linux machine I now get the 64-bit windows download (I have to navigate manually to /download/win, of course). And those two things may or may not be correlated, since I'm clearly not downloading for my current platform. 😉 I think that's the best we can do for the auto-download, though.

@aaronfranke aaronfranke deleted the x64 branch May 27, 2020 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

64-bit detection doesn't work if the user agent string is missing "Win64"
2 participants