Skip to content

Failed to update the excludes stack to see if a path is excluded #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
neerajjain92 opened this issue May 28, 2024 · 4 comments · Fixed by #3883
Closed

Failed to update the excludes stack to see if a path is excluded #3876

neerajjain92 opened this issue May 28, 2024 · 4 comments · Fixed by #3883
Assignees
Labels
bug Something isn't working 🦀gitoxide🦀 `gitoxide` might help here

Comments

@neerajjain92
Copy link

I am trying to import a project in gitbutler app, here is the repo https://github.com/neerajjain92/data-structures but getting error

There was a problem
Failed to update the excludes stack to see if a path is excluded

Screenshot 2024-05-28 at 3 45 28 PM
@neerajjain92
Copy link
Author

I have identified the issue. The problem occurred because GitButler was attempting to locate a .gitignore file, but due to a mix-up, the .gitignore was mistakenly created as a folder in my repository. This caused GitButler to throw an error.

However, the error message provided was not very informative and did not clearly indicate the steps needed to resolve the issue.

@Byron Byron added bug Something isn't working 🦀gitoxide🦀 `gitoxide` might help here labels May 28, 2024
@Byron Byron self-assigned this May 28, 2024
@Byron
Copy link
Collaborator

Byron commented May 28, 2024

That's an amazing find, thanks so much for reporting!

I can reproduce the issue and it looks like Git just ignores directories with this name. Clearly, .gitoxide should do the same.
(Note to self: also validate .gitattribute files, they are probably similar).

Byron added a commit to Byron/gitbutler that referenced this issue May 28, 2024
… `.gitignore` (gitbutlerapp#3876)

This is also effective for `.gitattributes` directories, making `gitoxide`
act just like Git.

Note that `gix-fs` is updated just for a potential Windows fix which probably
doesn't matter.
@neerajjain92
Copy link
Author

Thanks a lot @Byron for a prompt response

@Byron
Copy link
Collaborator

Byron commented May 29, 2024

You are very welcome! Actually gitoxide already tried to ignore directories, but a test was missing and it didn't actually work due to unfortunate reasons.

Please do try the nightly build tomorrow (to be sure the fix is in), it should work then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🦀gitoxide🦀 `gitoxide` might help here
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants