Skip to content

Delete Branch can be triggered multiple times #4794

@Byron

Description

@Byron

Version

0.12.21

Operating System

Mac OS X

Distribution Method

dmg (Apple Silicon)

Describe the issue

The Delete button for virtual branch deletion receives clicks and doesn't indicate it's doing anything, even though each click counts and triggers a delete action (visible in the log).
This is most noticeable in big repositories, and probably doesn't matter in smaller ones.

How to reproduce

  • Create a virtual branch from an existing on in the GitLab (https://gitlab.com/gitlab-org/gitlab) repository
  • Delete the branch so the popup shows:
    Screenshot 2024-08-29 at 16 36 07
  • Click the Delete button - it will receive any click while the popup is visible, and trigger a delete operation each time.

Expected behavior

The Delete button is greyed out and can't be clicked until the operation completes. If the operation fails, the popup should probably remain visible.

Relevant log output

No response

Metadata

Metadata

Assignees

Labels

UIAny broken visuals like layouts, colors etc.bugSomething isn't working🎉reproduced🎉The issue could be reproduced by following the instructions

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions