-
Notifications
You must be signed in to change notification settings - Fork 691
Svelte Login migration PT II #9626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
estib-vega
wants to merge
35
commits into
master
Choose a base branch
from
svelte-login-migration-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
958e3c8
to
a26bbfd
Compare
a26bbfd
to
03a7a70
Compare
03a7a70
to
a79ace9
Compare
cd64787
to
6c7658a
Compare
Add reusable OAuth login button components (GitHub and Google) for use on login/signup pages. Each button includes style and click logic for OAuth redirect.
Google password generator doesn't include special character
Replaces the reset password page with a new forgot password page and updates routing accordingly. Improves responsive styles for auth and footer components, and adjusts text line heights for accent serif headings. Also adds a new accent line height token to design tokens.
Renamed PasswordPageLayout to AuthUtilityLayout and updated confirm-password, forgot-password, and resend-confirmation pages to use the new layout. Simplified and unified the resend-confirmation page UI, replacing custom markup with shared components (EmailTextbox, InfoMessage). Also removed the default placeholder from EmailTextbox.
Introduces an 'oauthMode' prop to AuthPageLayout and OAuthButtons to distinguish between 'signin' and 'signup' flows, updating button text accordingly. Updates login and signup pages to use the correct mode, and refines layout logic for finalized pages and navigation visibility. Also adds an optional 'showBackLink' prop to AuthUtilityLayout.
053ff02
to
8d71696
Compare
Added optional illustration prop to FullscreenIllustrationCard for customizable illustrations. Updated the profile finalize page to use a specific illustration. Improved signup page UX by displaying a success message and adjusting form/footers accordingly. Fixed OAuthButtons placement in the login form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description