-
-
Notifications
You must be signed in to change notification settings - Fork 12
Update for Git Extensions 6 #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I can build, but when running the 0.3 plugins are still installable (I copied the binary manually). |
It is built (and of course require) .net8 and do not limit 0.3 plugins |
GitExtensions.Extensibility.dll is not coming from I have validated local build - it requires .NET 9 to run Git Extensions (6.0.1.18221). The plugin manager can start from the plugins menu and search for packages. It filters out packages correctly. There is a bit of a problem with how existing nuget plugins define a dependency on GitExtensions.Extensibility, for example https://www.nuget.org/packages/GitExtensions.GerritPlugin/1.3.1.116#dependencies-body-tab (a historic version of Gerrit), it states is supports |
I unlisted 1.3.1.116, thanks |
Yep :( I couldn't win that argument, so the extensibility API are in the main repo. |
We need to update https://github.com/gitextensions/gitextensions.plugintemplate/blob/master/src/GitExtensions.PluginTemplate/GitExtensions.PluginTemplate.nuspec with the current version and limit to less than 1.0. The Gerrit plugin still uses the 0.3 version. The plugins to install is not limited by version, but installed incompatible versions are listed as incompatible. I expected that GitExtensions.Extensibility took a snapshot of master when publishing the package. |
Updated dependency version range for GitExtensions.Extensibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would assume this is ready to be merged, needed for GE6
(the problem with Gerrit plugin is maybe separate)
Any specific that need tobe done before making a release with this commit? |
IIRC no |
I published a draft release, seem to be sufficient for the GE build. |
No description provided.