Skip to content

Conversation

maraf
Copy link
Member

@maraf maraf commented Aug 26, 2025

No description provided.

@gerhardol
Copy link
Member

I can build, but when running the 0.3 plugins are still installable (I copied the binary manually).
GitExtensions.Extensibility.dll is from January, not updated for some reason also with full match - then the package is not found.
Tests fail, but they try to test with latest 5.2.1

@gerhardol
Copy link
Member

It is built (and of course require) .net8 and do not limit 0.3 plugins

@maraf
Copy link
Member Author

maraf commented Aug 27, 2025

GitExtensions.Extensibility.dll is not coming from
GitExtensions.Extensibility package (see gitextensions/gitextensions.extensibility#31). It is still in the main repo. To get a newer dll (and the whole Git Extensions) you need to delete the GitExtensions.Shared folder one level above the PluginManager repository. If there is no Git Extensions portable found, it tries to download latest.

I have validated local build - it requires .NET 9 to run Git Extensions (6.0.1.18221). The plugin manager can start from the plugins menu and search for packages. It filters out packages correctly.

There is a bit of a problem with how existing nuget plugins define a dependency on GitExtensions.Extensibility, for example https://www.nuget.org/packages/GitExtensions.GerritPlugin/1.3.1.116#dependencies-body-tab (a historic version of Gerrit), it states is supports [0.1.0, 1.0.0) which is incorrect. Newer versions have it setup correctly, like [0.3.0, 0.4.0) for previous Git Extensions version. For Git Extensions v6 it should be [0.4.0, 0.5.0). We might want hide the historic versions on nuget.org to prevent a confusion.

@RussKie
Copy link
Member

RussKie commented Aug 27, 2025

I unlisted 1.3.1.116, thanks
Do you think we should unlist any others?

@RussKie
Copy link
Member

RussKie commented Aug 27, 2025

GitExtensions.Extensibility.dll is not coming from GitExtensions.Extensibility package (see gitextensions/gitextensions.extensibility#31). It is still in the main repo.

Yep :( I couldn't win that argument, so the extensibility API are in the main repo.

@gerhardol
Copy link
Member

gerhardol commented Aug 27, 2025

We need to update https://github.com/gitextensions/gitextensions.plugintemplate/blob/master/src/GitExtensions.PluginTemplate/GitExtensions.PluginTemplate.nuspec with the current version and limit to less than 1.0.
I can see that for instance https://github.com/jasparfitt/GitExtensions.BranchNameCommitHintPlugin/blob/master/src/GitExtensions.BranchNameCommitHintPlugin/GitExtensions.BranchNameCommitHintPlugin.nuspec use 1.0

The Gerrit plugin still uses the 0.3 version.
gitextensions/GitExtensions.GerritPlugin#89

The plugins to install is not limited by version, but installed incompatible versions are listed as incompatible.
It did not work initially for me as I replaced the binary in the installation folder, not in C:\Users\user\AppData\Local\GitExtensions\UserPlugins

I expected that GitExtensions.Extensibility took a snapshot of master when publishing the package.

Updated dependency version range for GitExtensions.Extensibility.
Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume this is ready to be merged, needed for GE6
(the problem with Gerrit plugin is maybe separate)

@maraf maraf merged commit 7ae7b42 into master Sep 1, 2025
3 checks passed
@maraf maraf deleted the feature/ge6 branch September 1, 2025 10:44
@gerhardol
Copy link
Member

Any specific that need tobe done before making a release with this commit?
GE build looks for releases, so 6.0.1 is not having a plugin manager at all

@maraf
Copy link
Member Author

maraf commented Sep 19, 2025

IIRC no

@RussKie
Copy link
Member

RussKie commented Sep 19, 2025

@gerhardol
Copy link
Member

We need to release it? https://github.com/gitextensions/gitextensions/blob/d76d46a393ac036cc5635d2b3f7a07d6f46ca75c/eng/Download-PluginManager.ps1#L10

I published a draft release, seem to be sufficient for the GE build.
Should be promoted, I just was not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants