Migrate theming from net461 to net50

[NikolayXHD]

Beginning of discussion: #8522 (comment)

[RussKie]

Have you seen https://github.com/Microsoft/Detours?

[RussKie]

...and https://github.com/citronneur/detours.net?

[NikolayXHD]

Thank you, will look at it the coming weekend

[NikolayXHD]

@NikolayXHD if you run with the Managed Debug Assistants turned on in VS, do they flag any kind of interop issues? It may be that a calling convention or argument marshalling is incorrectly specified, and that it worked under .NET Framework but fails under .NET Core.

Thank you, good to know it exists! Gave it a shot, unfortunately it no new information so far.
The program loads a bunch of DLLs, then ExecutionEngineException, nothing intercepted or outputted in between

[NikolayXHD]

...and https://github.com/citronneur/detours.net?

detours.net should be able to achieve what we need, not directly though.

.\DetoursNetRuntime myplugin.dll process_to_inject_hooks_into.exe

is not what we want. The goal would be to achieve hooking "from inside" a .net process by learning from detours.net codebase.

Plan

1. Make sure the detours.net suggested approach is able to hook the theming api functions we need.
   At this point, if successfull, we at least know that detours can do the job, with or without detours.net.
2. Achieve hooking from within the process.

point 1. Should be relatively straightforward
point 2. May prove difficult, however, the fact that detours.net codebase is not huge at all, suggests that using original detours from .NET is doable with moderate effort.

[sharwell]

is there a list of the APIs that are currently hooked for theming?

[NikolayXHD]

8 methods, see Win32ThemeHooks.InstallHooks

[KindDragon]

Related WinForms issue dotnet/winforms#5166

[macsux]

I had success getting CoreHook to work with .net core as replacement for easyhook. https://github.com/unknownv2/CoreHook