-
Notifications
You must be signed in to change notification settings - Fork 4
Consolidate the sync-*
workflows
#12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In the upcoming work to support a project other than Git, we will need to synchronize a different upstream repository to a different "PR repository". To that end, let's consolidate `sync-git-gui` and `sync-gitster-git` into a single, matrix workflow that will continue to synchronize the Git GUI and the fine-grained branches from `gitster/git` to `gitgitgadget/git`, but can be overridden in another fork of `gitgitgadget-workflows` via a repository variable that contains the project config to perform the equivalent job of synchronizing upstream branches into the repository where GitGitGadget handles the Pull Requests for said project. This is step 1 to support that: renaming the `sync-git-gui` workflow to `sync-upstream-branches`. Subsequent commits will transmogrify that workflow into the desired shape. Signed-off-by: Johannes Schindelin <[email protected]>
The workflow still only handles the `git-gui` branches, but is now almost generic enough to become a matrix workflow that also handles the `gitster/git` synchronization. Signed-off-by: Johannes Schindelin <[email protected]>
This still does the exact same thing, but avoids storing intermediate states of the `data` array's transformation. Signed-off-by: Johannes Schindelin <[email protected]>
…orkflow With a few touch-ups, the workflow can become generic enough to handle also the synchronization of `gitster/git`'s branches to `gitgitgadget/git`. The overall goal, of course, is to prepare for supporting projects other than Git, via configurations stored in repository variables. That's the task of the next commit(s). Signed-off-by: Johannes Schindelin <[email protected]>
I want to use the same workflow in a fork to synchronize _Cygwin's_ mailing list mirror; Let's rename the workflow and its job so that it stops claiming to synchronize _Git's_ mailing list mirror. Signed-off-by: Johannes Schindelin <[email protected]>
Rather than hard-coding the exact minutes at which the workflow should run, just specify that it should run every five minutes, and leave it to GitHub to figure out the specifics. Signed-off-by: Johannes Schindelin <[email protected]>
36d1292
to
3c327fc
Compare
I also noticed that it makes no sense to introduce kebap-cased matrix variables only to switch them to CamelCased ones later. Instead, I now introduce CamelCased ones right away. Range-diff
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let you complete this so you can control the timing.
In preparation for supporting projects other than Git, let's combine the
sync-git-gui
andsync-gitster-git
workflows into a single, matrix one. The next step after that will be to define the project-specific parts in a project configuration and consume it from there.While at it, also rename the workflow that synchronizes the mailing list mirror, so that it does not talk about Git specifically.