Unlock on Merge - Minor Improvements #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or non-merged pull requests
There was a problem hiding this comment.
Pull Request Overview
This PR improves the error handling for the "Unlock on Merge" workflow by making it more graceful when run in incorrect contexts. Instead of failing with an error, the workflow now logs warnings and exits cleanly, which is more appropriate for automated workflows that may be triggered in various contexts.
- Replaces
core.setFailed()withcore.warning()for invalid workflow contexts - Adds specific informational logging for closed but unmerged pull requests
- Updates tests to reflect the new warning-based approach instead of failure-based approach
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/functions/unlock-on-merge.js | Changes error handling from failure to warning with additional context logging |
| tests/functions/unlock-on-merge.test.js | Updates test mocks and adds test case for closed but unmerged PR scenario |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes it so that the "Unlock on Merge" sub-workflow of this Action does not fail when run in an unknown context and instead just logs a warning and exits.
resolves: #403