Fix Go tracing on Windows, and fix tests

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## [UNRELEASED]
 
 - Improve error messages when the code scanning configuration file includes an invalid `queries` block or an invalid `query-filters` block. [#1208](https://github.com/github/codeql-action/pull/1208)
+- Fix a bug where Go build tracing could fail on Windows. [#1209](https://github.com/github/codeql-action/pull/1209)
 
 ## 2.1.20 - 22 Aug 2022
 

pr-checks/checks/go-custom-tracing-autobuild.yml

@@ -2,7 +2,7 @@ name: "Go: Autobuild custom tracing"
 description: "Checks that Go tracing works in conjunction with the autobuilder"
 os: ["ubuntu-latest", "macos-latest"]
 env:
-  CODEQL_EXTRACTOR_GO_BUILD_TRACING: "true"
+  CODEQL_EXTRACTOR_GO_BUILD_TRACING: "on"
 steps:
   - uses: actions/setup-go@v3
     with:

pr-checks/checks/go-custom-tracing.yml

@@ -1,7 +1,7 @@
 name: "Go: Custom tracing"
 description: "Checks that Go tracing works"
 env:
-  CODEQL_EXTRACTOR_GO_BUILD_TRACING: "true"
+  CODEQL_EXTRACTOR_GO_BUILD_TRACING: "on"
 steps:
   - uses: actions/setup-go@v3
     with:

src/codeql.ts

@@ -789,7 +789,17 @@ async function getCodeQLForCmd(
         if (
           await util.codeQlVersionAbove(this, CODEQL_VERSION_LUA_TRACER_CONFIG)
         ) {
-          if (await featureFlags.getValue(FeatureFlag.LuaTracerConfigEnabled)) {
+          if (
+            (await featureFlags.getValue(FeatureFlag.LuaTracerConfigEnabled)) &&
+            // There's a bug in Lua tracing for Go on Windows in versions 2.10.3 and earlier,
+            // so don't use Lua tracing when tracing Go on Windows.
+            // Once we've released a fix, we should add a version gate based on the fixed version.
+            !(
+              config.languages.includes(Language.go) &&
+              isTracedLanguage(Language.go) &&
+              process.platform === "win32"
+            )
+          ) {
             extraArgs.push("--internal-use-lua-tracing");
           } else {
             extraArgs.push("--no-internal-use-lua-tracing");

src/languages.ts

@@ -37,6 +37,13 @@ export function parseLanguage(language: string): Language | undefined {
 }
 
 export function isTracedLanguage(language: Language): boolean {
+  if (process.env["CODEQL_EXTRACTOR_GO_BUILD_TRACING"] === "true") {
+    throw new Error(
+      "The CODEQL_EXTRACTOR_GO_BUILD_TRACING environment variable is set to an invalid value. " +
+        "To enable Go build tracing, please set it to 'on'."
+    );
+  }
+
   return (
     ["cpp", "java", "csharp", "swift"].includes(language) ||
     (process.env["CODEQL_EXTRACTOR_GO_BUILD_TRACING"] === "on" &&