-
Notifications
You must be signed in to change notification settings - Fork 394
Update unset environment variables PR check #1269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ab921b6
Only test Java for CLI v2.5+
angelapwen 81e0392
Add explanation in PR check comment
angelapwen 2bdcdfe
Improve bash code style
angelapwen 50fd69b
Bash syntax fixups
angelapwen bf48a18
Fix typo
angelapwen d224372
Print variables for debugging
angelapwen 8374a4e
Fix more bash typos
angelapwen 8024938
Fix bash syntax bugs
angelapwen 231835d
Set Actions error messages
angelapwen e161371
Add whitespace
angelapwen 9d42ae7
Replace `*` matching in bash script
angelapwen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| # See `unset-environment-old-cli.yml` for reasoning behind the separate tests. | ||
| name: PR Check - Test unsetting environment variables for CLI version >= 2.5.1 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GO111MODULE: auto | ||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - releases/v1 | ||
| - releases/v2 | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - synchronize | ||
| - reopened | ||
| - ready_for_review | ||
| workflow_dispatch: {} | ||
| jobs: | ||
| unset-environment: | ||
| strategy: | ||
| matrix: | ||
| include: | ||
| - os: ubuntu-latest | ||
| version: stable-20210809 | ||
| - os: ubuntu-latest | ||
| version: cached | ||
| - os: ubuntu-latest | ||
| version: latest | ||
| - os: ubuntu-latest | ||
| version: nightly-latest | ||
| name: Test unsetting environment variables | ||
| timeout-minutes: 45 | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - name: Check out repository | ||
| uses: actions/checkout@v3 | ||
| - name: Prepare test | ||
| id: prepare-test | ||
| uses: ./.github/prepare-test | ||
| with: | ||
| version: ${{ matrix.version }} | ||
| - uses: ./../action/init | ||
| with: | ||
| db-location: ${{ runner.temp }}/customDbLocation | ||
| tools: ${{ steps.prepare-test.outputs.tools-url }} | ||
| env: | ||
| TEST_MODE: true | ||
| - name: Build code | ||
| shell: bash | ||
| run: env -i PATH="$PATH" HOME="$HOME" ./build.sh | ||
| - uses: ./../action/analyze | ||
| id: analysis | ||
| env: | ||
| TEST_MODE: true | ||
| - shell: bash | ||
| run: | | ||
| CPP_DB="${{ fromJson(steps.analysis.outputs.db-locations).cpp }}" | ||
| if [[ ! -d "$CPP_DB" ]] || [[ ! "$CPP_DB" == "${RUNNER_TEMP}/customDbLocation/cpp" ]]; then | ||
| echo "::error::Did not create a database for CPP, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/cpp' but actual was '${CPP_DB}'" | ||
| exit 1 | ||
| fi | ||
| CSHARP_DB="${{ fromJson(steps.analysis.outputs.db-locations).csharp }}" | ||
| if [[ ! -d "$CSHARP_DB" ]] || [[ ! "$CSHARP_DB" == "${RUNNER_TEMP}/customDbLocation/csharp" ]]; then | ||
| echo "::error::Did not create a database for C Sharp, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/csharp' but actual was '${CSHARP_DB}'" | ||
| exit 1 | ||
| fi | ||
| GO_DB="${{ fromJson(steps.analysis.outputs.db-locations).go }}" | ||
| if [[ ! -d "$GO_DB" ]] || [[ ! "$GO_DB" == "${RUNNER_TEMP}/customDbLocation/go" ]]; then | ||
| echo "::error::Did not create a database for Go, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/go' but actual was '${GO_DB}'" | ||
| exit 1 | ||
| fi | ||
| JAVA_DB="${{ fromJson(steps.analysis.outputs.db-locations).java }}" | ||
| if [[ ! -d "$JAVA_DB" ]] || [[ ! "$JAVA_DB" == "${RUNNER_TEMP}/customDbLocation/java" ]]; then | ||
| echo "::error::Did not create a database for Java, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/java' but actual was '${JAVA_DB}'" | ||
| exit 1 | ||
| fi | ||
| JAVASCRIPT_DB="${{ fromJson(steps.analysis.outputs.db-locations).javascript }}" | ||
| if [[ ! -d "$JAVASCRIPT_DB" ]] || [[ ! "$JAVASCRIPT_DB" == "${RUNNER_TEMP}/customDbLocation/javascript" ]]; then | ||
| echo "::error::Did not create a database for Javascript, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/javascript' but actual was '${JAVASCRIPT_DB}'" | ||
| exit 1 | ||
| fi | ||
| PYTHON_DB="${{ fromJson(steps.analysis.outputs.db-locations).python }}" | ||
| if [[ ! -d "$PYTHON_DB" ]] || [[ ! "$PYTHON_DB" == "${RUNNER_TEMP}/customDbLocation/python" ]]; then | ||
| echo "::error::Did not create a database for Python, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/python' but actual was '${PYTHON_DB}'" | ||
| exit 1 | ||
| fi | ||
| env: | ||
| INTERNAL_CODEQL_ACTION_DEBUG_LOC: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| # There was a bug, fixed in CLI v2.5.1, that didn't propagate environment | ||
| # variables that the Java tracer needed. Here we test all languages | ||
| # except Java for these CLI versions. In `unset-environment-new-cli.yml` | ||
| # we test all languages for recent CLI versions. | ||
| name: PR Check - Test unsetting environment variables for CLI version < 2.5.1 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GO111MODULE: auto | ||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - releases/v1 | ||
| - releases/v2 | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - synchronize | ||
| - reopened | ||
| - ready_for_review | ||
| workflow_dispatch: {} | ||
| jobs: | ||
| unset-environment: | ||
| strategy: | ||
| matrix: | ||
| include: | ||
| - os: ubuntu-latest | ||
| version: stable-20210308 | ||
| - os: ubuntu-latest | ||
| version: stable-20210319 | ||
| name: Test unsetting environment variables | ||
| timeout-minutes: 45 | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - name: Check out repository | ||
| uses: actions/checkout@v3 | ||
| - name: Prepare test | ||
| id: prepare-test | ||
| uses: ./.github/prepare-test | ||
| with: | ||
| version: ${{ matrix.version }} | ||
| - uses: ./../action/init | ||
| with: | ||
| languages: csharp,cpp,go,javascript,python | ||
| db-location: ${{ runner.temp }}/customDbLocation | ||
| tools: ${{ steps.prepare-test.outputs.tools-url }} | ||
| env: | ||
| TEST_MODE: true | ||
| - name: Build code | ||
| shell: bash | ||
| run: env -i PATH="$PATH" HOME="$HOME" ./build.sh | ||
| - uses: ./../action/analyze | ||
| id: analysis | ||
| env: | ||
| TEST_MODE: true | ||
| - shell: bash | ||
| run: | | ||
| CPP_DB="${{ fromJson(steps.analysis.outputs.db-locations).cpp }}" | ||
| if [[ ! -d "$CPP_DB" ]] || [[ ! "$CPP_DB" == "${RUNNER_TEMP}/customDbLocation/cpp" ]]; then | ||
| echo "::error::Did not create a database for CPP, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/cpp' but actual was '${CPP_DB}'" | ||
| exit 1 | ||
| fi | ||
| CSHARP_DB="${{ fromJson(steps.analysis.outputs.db-locations).csharp }}" | ||
| if [[ ! -d "$CSHARP_DB" ]] || [[ ! "$CSHARP_DB" == "${RUNNER_TEMP}/customDbLocation/csharp" ]]; then | ||
| echo "::error::Did not create a database for C Sharp, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/csharp' but actual was '${CSHARP_DB}'" | ||
| exit 1 | ||
| fi | ||
| GO_DB="${{ fromJson(steps.analysis.outputs.db-locations).go }}" | ||
| if [[ ! -d "$GO_DB" ]] || [[ ! "$GO_DB" == "${RUNNER_TEMP}/customDbLocation/go" ]]; then | ||
| echo "::error::Did not create a database for Go, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/go' but actual was '${GO_DB}'" | ||
| exit 1 | ||
| fi | ||
| JAVASCRIPT_DB="${{ fromJson(steps.analysis.outputs.db-locations).javascript }}" | ||
| if [[ ! -d "$JAVASCRIPT_DB" ]] || [[ ! "$JAVASCRIPT_DB" == "${RUNNER_TEMP}/customDbLocation/javascript" ]]; then | ||
| echo "::error::Did not create a database for Javascript, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/javascript' but actual was '${JAVASCRIPT_DB}'" | ||
| exit 1 | ||
| fi | ||
| PYTHON_DB="${{ fromJson(steps.analysis.outputs.db-locations).python }}" | ||
| if [[ ! -d "$PYTHON_DB" ]] || [[ ! "$PYTHON_DB" == "${RUNNER_TEMP}/customDbLocation/python" ]]; then | ||
| echo "::error::Did not create a database for Python, or created it in the wrong location." \ | ||
| "Expected location was '${RUNNER_TEMP}/customDbLocation/python' but actual was '${PYTHON_DB}'" | ||
| exit 1 | ||
| fi | ||
| env: | ||
| INTERNAL_CODEQL_ACTION_DEBUG_LOC: true |
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much we can do about this, but we will need to remember to change this when we no longer support CLI v2.5.9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, agreed (it's also present in all the other PR checks so we can change them all at once).