Only enable Java dependency minimisation when caching is enabled #3113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrolfe
force-pushed
the
nickrolfe/minimize-jars-followup
branch
from
8b2db72 to
4014b75
Compare
mbg
approved these changes
Sep 15, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refines the Java dependency minimization feature to only enable it when dependency caching is active, avoiding unnecessary performance overhead when caching is disabled.
- Adds an additional condition to check if dependency caching is enabled before setting the Java extractor environment variable
- Updates the comment to clarify the reasoning behind this optimization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/init-action.ts | Adds dependency caching check to Java jar minimization logic and updates explanatory comment |
| lib/init-action.js | Generated JavaScript output (not reviewed per guidelines) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3107 so that we don't bother setting the extractor flag when dependency caching is disabled, since the feature has a performance cost.
In the long term — when we remove the feature flag and enable it permanently — we'll want to come up with a more language-agnostic solution for this.